Changeset 31308

Timestamp:

01/30/2015 07:28:27 PM (10 years ago)

Author:

boonebgorges

Message:

Fix 'quick_edit_show_taxonomy' filter so that can properly be used for overrides in all cases.

See #26948.

File:

• trunk/src/wp-admin/includes/class-wp-posts-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -946 +946 @@
         foreach ( $taxonomy_names as $taxonomy_name ) {
 
+            $taxonomy = get_taxonomy( $taxonomy_name );
+
+            $show_in_quick_edit = $taxonomy->show_in_quick_edit;
+
             /**
              * Filters whether the current taxonomy should be shown in the Quick Edit panel.
@@ -951 +955 @@
              * @since 4.2.0
              *
-             * @param bool   $show          Whether to show the current taxonomy in Quick Edit.
-             *                              Default: true.
-             * @param string $taxonomy_name Taxonomy name.
-             * @param string $post_type     Post type of current Quick Edit post.
+             * @param bool   $show_in_quick_edit Whether to show the current taxonomy in Quick Edit.
+             * @param string $taxonomy_name      Taxonomy name.
+             * @param string $post_type          Post type of current Quick Edit post.
              */
-            if ( ! apply_filters( 'quick_edit_show_taxonomy', true, $taxonomy_name, $screen->post_type ) ) {
-                continue;
-            }
-
-            $taxonomy = get_taxonomy( $taxonomy_name );
-
-            if ( ! $taxonomy->show_in_quick_edit ) {
+            if ( ! apply_filters( 'quick_edit_show_taxonomy', $show_in_quick_edit, $taxonomy_name, $screen->post_type ) ) {
                 continue;
             }