Changeset 31321

Timestamp:

02/01/2015 08:25:42 PM (10 years ago)

Author:

boonebgorges

Message:

When querying for a specific post, allow posts with a non-public status to be returned as long as that status is specified.

This makes it possible to, for example, retrieve a specific post using the
p parameter of WP_Query, even if the post is in the Trash, by including
the post_status=trash parameter.

Props ebinnion.
Fixes #29167.

Location:

trunk

Files:

• src/wp-includes/query.php (modified) (2 diffs)
• tests/phpunit/tests/query/postStatus.php (modified) (1 diff)

trunk/src/wp-includes/query.php

@@ -2964 +2964 @@
         $user_id = get_current_user_id();
 
+        $q_status = array();
         if ( ! empty( $q['post_status'] ) ) {
             $statuswheres = array();
@@ -3528 +3529 @@
             $post_status_obj = get_post_status_object($status);
             //$type = get_post_type($this->posts[0]);
-            if ( !$post_status_obj->public ) {
+
+            // If the post_status was specifically requested, let it pass through.
+            if ( !$post_status_obj->public && ! in_array( $status, $q_status ) ) {
+
                 if ( ! is_user_logged_in() ) {
                     // User must be logged in to view unpublished posts.

trunk/tests/phpunit/tests/query/postStatus.php

@@ -299 +299 @@
         $this->assertEmpty( $q->posts );
     }
+
+    /**
+     * @ticket 29167
+     */
+    public function test_specific_post_should_be_returned_if_trash_is_one_of_the_requested_post_statuses() {
+        $p1 = $this->factory->post->create( array( 'post_status' => 'trash' ) );
+        $p2 = $this->factory->post->create( array( 'post_status' => 'publish' ) );
+
+        $q = new WP_Query( array(
+            'p' => $p1,
+            'post_status' => array( 'trash', 'publish' ),
+        ) );
+
+        $this->assertContains( $p1, wp_list_pluck( $q->posts, 'ID' ) );
+    }
 }