Changeset 31324

Timestamp:

02/03/2015 02:28:52 AM (10 years ago)

Author:

SergeyBiryukov

Message:

When using WP_Query's 'fields' => 'ids' (or 'fields' => 'id=>parent'), make sure the returned result is always an array of integers.

fixes #31194. see #27252.

Location:

trunk

Files:

• src/wp-includes/query.php (modified) (2 diffs)
• tests/phpunit/tests/query/results.php (modified) (3 diffs)

trunk/src/wp-includes/query.php

@@ -3422 +3422 @@
         if ( 'ids' == $q['fields'] ) {
             $this->posts = $wpdb->get_col( $this->request );
+            $this->posts = array_map( 'intval', $this->posts );
             $this->post_count = count( $this->posts );
             $this->set_found_posts( $q, $limits );
 
-            return array_map( 'intval', $this->posts );
+            return $this->posts;
         }
 
@@ -3434 +3435 @@
 
             $r = array();
-            foreach ( $this->posts as $post ) {
+            foreach ( $this->posts as $key => $post ) {
+                $this->posts[ $key ]->ID = (int) $post->ID;
+                $this->posts[ $key ]->post_parent = (int) $post->post_parent;
+
                 $r[ (int) $post->ID ] = (int) $post->post_parent;
             }
+
             return $r;
         }

trunk/tests/phpunit/tests/query/results.php

@@ -388 +388 @@
     /**
      * @ticket 27252
+     * @ticket 31194
      */
     function test_query_fields_integers() {
@@ -402 +403 @@
 
         $this->assertSame( $parents, $posts1 );
+        $this->assertSame( $parents, $this->q->posts );
 
         $children = array(
@@ -415 +417 @@
 
         $this->assertSame( $children, $posts2 );
+
+        foreach ( $this->q->posts as $post ) {
+            $this->assertInternalType( 'int', $post->ID );
+            $this->assertInternalType( 'int', $post->post_parent );
+        }
 
     }