Changeset 31329 for trunk/src/wp-includes/class-wp-customize-setting.php

Timestamp:

02/03/2015 10:14:28 AM (10 years ago)

Author:

ocean90

Message:

Ensure that WP_Customize_Setting::value() returns default value for setting if not dirty.

There was regression introduced by #28580 where only changed (dirty) settings now are POST'ed to the Customizer preview.

• Allow WP_Customize_Manager::post_value() to accept a second $default argument.
• Introduce WP_Customize_Manager::unsanitized_post_values() for accessing previously-private member variable _post_values.
• Do require_once instead of require for Customizer classes.
• Add unit tests for WP_Customize_Manager and WP_Customize_Setting.

props westonruter.
fixes #30988.

File:

• trunk/src/wp-includes/class-wp-customize-setting.php (modified) (4 diffs)

trunk/src/wp-includes/class-wp-customize-setting.php

@@ -101 +101 @@
     }
 
+    protected $_original_value;
+
     /**
      * Handle previewing the setting.
@@ -107 +109 @@
      */
     public function preview() {
+        if ( ! isset( $this->_original_value ) ) {
+            $this->_original_value = $this->value();
+        }
+
         switch( $this->type ) {
             case 'theme_mod' :
@@ -157 +163 @@
      */
     public function _preview_filter( $original ) {
-        return $this->multidimensional_replace( $original, $this->id_data[ 'keys' ], $this->post_value() );
+        $undefined = new stdClass(); // symbol hack
+        $post_value = $this->manager->post_value( $this, $undefined );
+        if ( $undefined === $post_value ) {
+            $value = $this->_original_value;
+        } else {
+            $value = $post_value;
+        }
+
+        return $this->multidimensional_replace( $original, $this->id_data['keys'], $value );
     }
 
@@ -423 +437 @@
         }
 
-        if ( $create && ! isset( $node[ $last ] ) )
-            $node[ $last ] = array();
+        if ( $create ) {
+            if ( ! is_array( $node ) ) {
+                // account for an array overriding a string or object value
+                $node = array();
+            }
+            if ( ! isset( $node[ $last ] ) ) {
+                $node[ $last ] = array();
+            }
+        }
 
         if ( ! isset( $node[ $last ] ) )