Changeset 31338 for trunk/src/wp-includes/post-template.php

Timestamp:

02/05/2015 07:03:52 PM (10 years ago)

Author:

boonebgorges

Message:

Introduce 'value_field' parameter to wp_dropdown_pages().

This parameter allows developers to choose the post field that will be used to
fill in the 'option' attribute of the generated dropdown markup.

See [31006] #30306 for a parallel enhancement in wp_dropdown_categories().

Props jfarthing84.
Fixes #12494.

File:

• trunk/src/wp-includes/post-template.php (modified) (3 diffs)

trunk/src/wp-includes/post-template.php

@@ -972 +972 @@
         'name' => 'page_id', 'id' => '',
         'show_option_none' => '', 'show_option_no_change' => '',
-        'option_none_value' => ''
+        'option_none_value' => '',
+        'value_field' => 'ID',
     );
 
@@ -1426 +1427 @@
      *
      * @param string $output Passed by reference. Used to append additional content.
-     * @param object $page Page data object.
-     * @param int $depth Depth of page in reference to parent pages. Used for padding.
-     * @param array $args Uses 'selected' argument for selected page to set selected HTML attribute for option element.
+     * @param object $page   Page data object.
+     * @param int    $depth  Depth of page in reference to parent pages. Used for padding.
+     * @param array  $args   Uses 'selected' argument for selected page to set selected HTML attribute for option
+     *              element. Uses 'value_field' argument to fill "value" attribute. See {@see wp_dropdown_pages()}.
      * @param int $id
      */
@@ -1434 +1436 @@
         $pad = str_repeat(' ', $depth * 3);
 
-        $output .= "\t<option class=\"level-$depth\" value=\"$page->ID\"";
+        if ( ! isset( $args['value_field'] ) || ! isset( $page->{$args['value_field']} ) ) {
+            $args['value_field'] = 'ID';
+        }
+
+        $output .= "\t<option class=\"level-$depth\" value=\"" . esc_attr( $page->{$args['value_field']} ) . "\"";
         if ( $page->ID == $args['selected'] )
             $output .= ' selected="selected"';