Changeset 31341

Timestamp:

02/05/2015 07:51:42 PM (10 years ago)

Author:

boonebgorges

Message:

jshint fixes for shiny updates JS.

As introduced in [31333].

Props iseulde.
See #29820.

Location:

trunk/src/wp-admin/js

Files:

• plugin-install.js (modified) (1 diff)
• updates.js (modified) (10 diffs)

trunk/src/wp-admin/js/plugin-install.js

@@ -1 @@
-/* global plugininstallL10n, tb_click, confirm */
+/* global plugininstallL10n, tb_click */
 
 /* Plugin Browser Thickbox related JS*/

trunk/src/wp-admin/js/updates.js

@@ -1 +1 @@
 window.wp = window.wp || {};
 
-(function( $, wp ) {
-
+(function( $, wp, pagenow, ajaxurl ) {
     wp.updates = {};
 
@@ -53 +52 @@
             pluginCount,
             $adminBarUpdateCount = $( '#wp-admin-bar-updates .ab-label' ),
-            $dashboardNavMenuUpdateCount = $( 'a[href="update-core.php"] .update-plugins' )
+            $dashboardNavMenuUpdateCount = $( 'a[href="update-core.php"] .update-plugins' ),
             $pluginsMenuItem = $( '#menu-plugins' );
 
@@ -154 +153 @@
                  alertText += ': ' + jqxhr.responseJSON.data.error;
             }
-            alert( alertText );
+            window.alert( alertText );
             if ( jqxhr.responseJSON && jqxhr.responseJSON.data && jqxhr.responseJSON.data.slug ) {
                 wp.updates.updateError( jqxhr.responseJSON );
@@ -163 +162 @@
          */
         wp.updates.queueChecker();
-    }
+    };
 
     /**
@@ -263 +262 @@
                  alertText += ': ' + jqxhr.responseJSON.data.error;
             }
-            alert( alertText );
+            window.alert( alertText );
             if ( jqxhr.responseJSON && jqxhr.responseJSON.data && jqxhr.responseJSON.data.slug ) {
                 wp.updates.installError( jqxhr.responseJSON );
@@ -323 +322 @@
                 break;
             default:
-                console.log( 'Failed to exect queued update job.' );
-                console.log( job );
+                window.console.log( 'Failed to exect queued update job.' );
+                window.console.log( job );
                 break;
         }
@@ -337 +336 @@
 
         $( '#bulk-action-form' ).on( 'submit', function( e ) {
-            var checkbox, plugin, slug;
+            var $checkbox, plugin, slug;
 
             if ( $( '#bulk-action-selector-top' ).val() == 'update-selected' ) {
@@ -356 +355 @@
         $( '.plugin-card .update-now' ).on( 'click', function( e ) {
             e.preventDefault();
-            $button = $( e.target );
+            var $button = $( e.target );
             wp.updates.updatePlugin( $button.data( 'plugin' ), $button.data( 'slug' ) );
         } );
@@ -362 +361 @@
         $( '.plugin-card .install-now' ).on( 'click', function( e ) {
             e.preventDefault();
-            $button = $( e.target );
+            var $button = $( e.target );
             if ( $button.hasClass( 'button-disabled' ) ) {
                 return;
@@ -390 +389 @@
     } );
 
-})( jQuery, window.wp );
+})( jQuery, window.wp, window.pagenow, window.ajaxurl );