Changeset 31388

Timestamp:

02/09/2015 07:26:56 PM (12 years ago)

Author:

jorbin

Message:

Use screen reader text instead of a title attribute in comments_popup_link

To better understand screen reader text, check out ​https://make.wordpress.org/accessibility/2015/02/09/hiding-text-for-screen-readers-with-wordpress-core/

Screen Reader text improves the user experience for screen reader users. It provides additional context for links, document forms and other pieces of a page that may exist visually, but are lost when looking only at the html of a site. This does change the output of comments_popup_link if you don't pass in values for $zero, $one, $more or $none. Theme authors can and should style <code>.screen-reader-text</code> in ways that are recommended in the above article to hide it visually.

Props joedolson
Fixes #26553

File:

• trunk/src/wp-includes/comment-template.php (modified) (3 diffs)

trunk/src/wp-includes/comment-template.php

@@ -1275 +1275 @@
 
         $id = get_the_ID();
-
-        if ( false === $zero ) $zero = __( 'No Comments' );
-        if ( false === $one ) $one = __( '1 Comment' );
-        if ( false === $more ) $more = __( '% Comments' );
-        if ( false === $none ) $none = __( 'Comments Off' );
-
+        $span = '<span class="screen-reader-text">';
+        $title = get_the_title();
+        $span_close = '</span>';
+        
         $number = get_comments_number( $id );
+        
+        if ( false === $zero ) $zero = sprintf( __( 'No Comments%1$s on %2$s%3$s' ), $span, $title, $span_close );
+        if ( false === $one ) $one = sprintf( __( '1 Comment%1$s on %2$s%3$s' ), $span, $title, $span_close );
+        if ( false === $more ) $more = sprintf( __( '%4$d Comments%1$s on %2$s%3$s' ), $span, $title, $span_close, $number );
+        if ( false === $none ) $none = sprintf( __( 'Comments Off%1$s on %2$s%3$s' ), $span, $title, $span_close );
 
         if ( 0 == $number && !comments_open() && !pings_open() ) {
@@ -1312 +1315 @@
                 echo ' class="'.$css_class.'" ';
         }
-        $title = the_title_attribute( array('echo' => 0 ) );
 
         $attributes = '';
@@ -1324 +1326 @@
         echo apply_filters( 'comments_popup_link_attributes', $attributes );
 
-        echo ' title="' . esc_attr( sprintf( __('Comment on %s'), $title ) ) . '">';
+        echo '>';
         comments_number( $zero, $one, $more );
         echo '</a>';