Changeset 31392

Timestamp:

02/09/2015 10:53:40 PM (10 years ago)

Author:

boonebgorges

Message:

Don't parse empty 'tax_input' keys in edit_post().

This fixes a bug introduced in [31359] where saving a tax_input that contained
only whitespace would result in a random tag being erroneously added to the
post.

See #30615.

Location:

trunk

Files:

• src/wp-admin/includes/post.php (modified) (1 diff)
• tests/phpunit/tests/admin/includesPost.php (modified) (1 diff)

trunk/src/wp-admin/includes/post.php

@@ -338 +338 @@
             $clean_terms = array();
             foreach ( $terms as $term ) {
+                // Empty terms are invalid input.
+                if ( empty( $term ) ) {
+                    continue;
+                }
+
                 $_term = get_terms( $taxonomy, array(
                     'name' => $term,

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -177 +177 @@
 
     /**
+     * @ticket 30615
+     */
+    public function test_edit_post_should_not_create_terms_for_an_empty_tag_input_field() {
+        $u = $this->factory->user->create( array( 'role' => 'editor' ) );
+        wp_set_current_user( $u );
+
+        register_taxonomy( 'wptests_tax', array( 'post' ) );
+        $t1 = $this->factory->term->create( array(
+            'taxonomy' => 'wptests_tax',
+            'name' => 'foo',
+            'slug' => 'bar',
+        ) );
+
+        $p = $this->factory->post->create();
+
+        $post_data = array(
+            'post_ID' => $p,
+            'tax_input' => array(
+                'wptests_tax' => ' ',
+            ),
+        );
+
+        edit_post( $post_data );
+
+        $found = wp_get_post_terms( $p, 'wptests_tax' );
+
+        $this->assertEmpty( $found );
+    }
+
+    /**
      * @ticket 27792
      */