Changeset 31458 for trunk/src/wp-includes/query.php

Timestamp:

02/14/2015 02:08:46 AM (10 years ago)

Author:

boonebgorges

Message:

More careful type conversion in WP_Query is_*() methods.

is_array( 1, '1-foo' ) returns true, which means that is_page( 1 )
was returning true when on a page with the slug '1-foo'. We avoid this odd
behavior by casting the queried object ID to a string before testing against
the value passed to the conditional function.

This also helps to avoid a problem where an arbitrary value for $page would
cause is_page( $page ) to return true if the query had been manipulated by
a plugin to show that the current page's ID is 0.

Props boonebgorges, r-a-y, nunomorgadinho, wonderboymusic, clifgriffin.
Fixes #24674.

File:

• trunk/src/wp-includes/query.php (modified) (6 diffs)

trunk/src/wp-includes/query.php

@@ -4078 +4078 @@
         $post_obj = $this->get_queried_object();
 
-        if ( in_array( $post_obj->ID, $attachment ) ) {
+        if ( in_array( (string) $post_obj->ID, $attachment ) ) {
             return true;
         } elseif ( in_array( $post_obj->post_title, $attachment ) ) {
@@ -4110 +4110 @@
         $author = (array) $author;
 
-        if ( in_array( $author_obj->ID, $author ) )
+        if ( in_array( (string) $author_obj->ID, $author ) )
             return true;
         elseif ( in_array( $author_obj->nickname, $author ) )
@@ -4142 +4142 @@
         $category = (array) $category;
 
-        if ( in_array( $cat_obj->term_id, $category ) )
+        if ( in_array( (string) $cat_obj->term_id, $category ) )
             return true;
         elseif ( in_array( $cat_obj->name, $category ) )
@@ -4174 +4174 @@
         $tag = (array) $tag;
 
-        if ( in_array( $tag_obj->term_id, $tag ) )
+        if ( in_array( (string) $tag_obj->term_id, $tag ) )
             return true;
         elseif ( in_array( $tag_obj->name, $tag ) )
@@ -4371 +4371 @@
         $page = (array) $page;
 
-        if ( in_array( $page_obj->ID, $page ) ) {
+        if ( in_array( (string) $page_obj->ID, $page ) ) {
             return true;
         } elseif ( in_array( $page_obj->post_title, $page ) ) {
@@ -4464 +4464 @@
         $post = (array) $post;
 
-        if ( in_array( $post_obj->ID, $post ) ) {
+        if ( in_array( (string) $post_obj->ID, $post ) ) {
             return true;
         } elseif ( in_array( $post_obj->post_title, $post ) ) {