Changeset 31473 for trunk/src/wp-includes/option.php

Timestamp:

02/18/2015 07:13:43 PM (11 years ago)

Author:

boonebgorges

Message:

Respect 'default_option_' filters during early sanity checks in add_option() and update_option().

add_option() and update_option() both call get_option() to compare the
value passed to the function with any existing value for the given option name.
When a 'default_option_' filter is in place to change the default value of
an option, add_option() and update_option() ought to check against the
filtered value, rather than a hardcoded false, in order to determine whether
a prior value exists.

Props GregLone, tyxla.
Fixes #31047.

File:

• trunk/src/wp-includes/option.php (modified) (2 diffs)

trunk/src/wp-includes/option.php

@@ -269 +269 @@
         return false;
 
-    if ( false === $old_value )
+    /** This filter is documented in wp-includes/option.php */
+    if ( apply_filters( 'default_option_' . $option, false ) === $old_value )
         return add_option( $option, $value );
 
@@ -371 +372 @@
     $notoptions = wp_cache_get( 'notoptions', 'options' );
     if ( !is_array( $notoptions ) || !isset( $notoptions[$option] ) )
-        if ( false !== get_option( $option ) )
+        /** This filter is documented in wp-includes/option.php */
+        if ( apply_filters( 'default_option_' . $option, false ) !== get_option( $option ) )
             return false;