Changeset 31515

Timestamp:

02/23/2015 01:07:18 AM (10 years ago)

Author:

boonebgorges

Message:

Ensure that a request URL is always set in WP_UnitTestCase::go_to().

Failure to set this variable meant that passing the home URL to go_to()
(without a trailing slash) resulted in a PHP notice, and failed to reset the
globals properly.

Props joostdevalk.
Fixes #31417.

Location:

trunk/tests/phpunit

Files:

• includes/testcase.php (modified) (1 diff)
• tests/includes/helpers.php (modified) (1 diff)

trunk/tests/phpunit/includes/testcase.php

@@ -334 +334 @@
         $parts = parse_url($url);
         if (isset($parts['scheme'])) {
-            $req = $parts['path'];
+            $req = isset( $parts['path'] ) ? $parts['path'] : '';
             if (isset($parts['query'])) {
                 $req .= '?' . $parts['query'];

trunk/tests/phpunit/tests/includes/helpers.php

@@ -186 +186 @@
     }
 
+    /**
+     * @ticket 31417
+     */
+    public function test_go_to_should_go_to_home_page_when_passing_the_untrailingslashed_home_url() {
+        $this->assertFalse( is_home() );
+        $home = untrailingslashit( get_option( 'home' ) );
+        $this->go_to( $home );
+        $this->assertTrue( is_home() );
+    }
+
     protected function mock_deprecated() {
         _deprecated_function( __METHOD__, '2.5' );