Changeset 31517 for trunk/src/wp-admin/network/site-settings.php

Timestamp:

02/23/2015 02:28:41 AM (10 years ago)

Author:

jeremyfelt

Message:

Provide proper label associations and descriptions throughout the network admin

• Add labels previously missing for many inputs throughout the network admin screen.
• Add proper aria-describedby attributes to provide better descriptions.
• Wrap grouped inputs with fieldset elements.
• Remove now unneeded title attributes when appropriate.

Props cfoellmann, afercia, rianrietveld.

Fixes #38406.

File:

• trunk/src/wp-admin/network/site-settings.php (modified) (2 diffs)

trunk/src/wp-admin/network/site-settings.php

@@ -139 +139 @@
             ?>
                 <tr class="form-field">
-                    <th scope="row"><?php echo ucwords( str_replace( "_", " ", $option->option_name ) ) ?></th>
+                    <th scope="row"><label for="<?php echo esc_attr( $option->option_name ) ?>"><?php echo ucwords( str_replace( "_", " ", $option->option_name ) ) ?></label></th>
                     <td><textarea class="<?php echo $class; ?>" rows="5" cols="40" name="option[<?php echo esc_attr( $option->option_name ) ?>]" id="<?php echo esc_attr( $option->option_name ) ?>"<?php disabled( $disabled ) ?>><?php echo esc_textarea( $option->option_value ) ?></textarea></td>
                 </tr>
@@ -146 +146 @@
             ?>
                 <tr class="form-field">
-                    <th scope="row"><?php echo esc_html( ucwords( str_replace( "_", " ", $option->option_name ) ) ); ?></th>
+                    <th scope="row"><label for="<?php echo esc_attr( $option->option_name ) ?>"><?php echo esc_html( ucwords( str_replace( "_", " ", $option->option_name ) ) ); ?></label></th>
                     <?php if ( $is_main_site && in_array( $option->option_name, array( 'siteurl', 'home' ) ) ) { ?>
                     <td><code><?php echo esc_html( $option->option_value ) ?></code></td>