Changeset 31517 for trunk/src/wp-admin/network/site-users.php

Timestamp:

02/23/2015 02:28:41 AM (11 years ago)

Author:

jeremyfelt

Message:

Provide proper label associations and descriptions throughout the network admin

• Add labels previously missing for many inputs throughout the network admin screen.
• Add proper aria-describedby attributes to provide better descriptions.
• Wrap grouped inputs with fieldset elements.
• Remove now unneeded title attributes when appropriate.

Props cfoellmann, afercia, rianrietveld.

Fixes #38406.

File:

• trunk/src/wp-admin/network/site-users.php (modified) (2 diffs)

trunk/src/wp-admin/network/site-users.php

@@ -263 +263 @@
         <table class="form-table">
                 <tr>
-                        <th scope="row"><?php _e( 'Username' ); ?></th>
+                        <th scope="row"><label for="newuser"><?php _e( 'Username' ); ?></label></th>
                         <td><input type="text" class="regular-text wp-suggest-user" name="newuser" id="newuser" /></td>
                 </tr>
                 <tr>
-                        <th scope="row"><?php _e( 'Role' ); ?></th>
-                        <td><select name="new_role" id="new_role_0">
+                        <th scope="row"><label for="new_role_adduser"><?php _e( 'Role' ); ?></label></th>
+                        <td><select name="new_role" id="new_role_adduser">
                         <?php wp_dropdown_roles( get_option( 'default_role' ) ); ?>
                         </select></td>
@@ -292 +292 @@
         <table class="form-table">
                 <tr>
-                        <th scope="row"><?php _e( 'Username' ) ?></th>
-                        <td><input type="text" class="regular-text" name="user[username]" /></td>
-                </tr>
-                <tr>
-                        <th scope="row"><?php _e( 'Email' ) ?></th>
-                        <td><input type="text" class="regular-text" name="user[email]" /></td>
-                </tr>
-                <tr>
-                        <th scope="row"><?php _e( 'Role' ); ?></th>
-                        <td><select name="new_role" id="new_role_0">
+                        <th scope="row"><label for="user_username"><?php _e( 'Username' ) ?></label></th>
+                        <td><input type="text" class="regular-text" name="user[username]" id="user_username" /></td>
+                </tr>
+                <tr>
+                        <th scope="row"><label for="user_email"><?php _e( 'Email' ) ?></label></th>
+                        <td><input type="text" class="regular-text" name="user[email]" id="user_email" /></td>
+                </tr>
+                <tr>
+                        <th scope="row"><label for="new_role_newuser"><?php _e( 'Role' ); ?></label></th>
+                        <td><select name="new_role" id="new_role_newuser">
                         <?php wp_dropdown_roles( get_option( 'default_role' ) ); ?>
                         </select></td>