Changeset 31550

Timestamp:

02/26/2015 02:46:40 AM (10 years ago)

Author:

helen

Message:

Hide irrelevant UI and display a message when editing the page for posts.

Users are frequently confused as to why the content they've entered or the page template they've selected doesn't apply for this one page. Showing and saving items that don't do anything hurts trust.

Developers can elect to turn on the editor should they be using it for something. If the content isn't empty, the editor will show so that users still have access to their content.

props alexkingorg for the initial, long-suffering patch.
fixes #17470.

Location:

trunk/src/wp-admin

Files:

• edit-form-advanced.php (modified) (1 diff)
• includes/meta-boxes.php (modified) (1 diff)
• includes/template.php (modified) (1 diff)

trunk/src/wp-admin/edit-form-advanced.php

@@ -45 +45 @@
 $user_ID = isset($user_ID) ? (int) $user_ID : 0;
 $action = isset($action) ? $action : '';
+
+if ( $post_ID == get_option( 'page_for_posts' ) && empty( $post->post_content ) ) {
+    add_action( 'edit_form_after_title', '_wp_posts_page_notice' );
+    remove_post_type_support( $post_type, 'editor' );
+}
 
 $thumbnail_support = current_theme_supports( 'post-thumbnails', $post_type ) && post_type_supports( $post_type, 'thumbnail' );

trunk/src/wp-admin/includes/meta-boxes.php

@@ -740 +740 @@
         } // end empty pages check
     } // end hierarchical check.
-    if ( 'page' == $post->post_type && 0 != count( get_page_templates( $post ) ) ) {
+    if ( 'page' == $post->post_type && 0 != count( get_page_templates( $post ) ) && get_option( 'page_for_posts' ) != $post->ID ) {
         $template = !empty($post->page_template) ? $post->page_template : false;
         ?>

trunk/src/wp-admin/includes/template.php

@@ -2170 +2170 @@
     echo '</div>';
 }
+
+/**
+ * Output a notice when editing the page for posts.
+ *
+ * @since 4.2.0
+ */
+function _wp_posts_page_notice() {
+    echo '<div class="notice notice-warning inline"><p>' . __( 'You are currently editing the page that shows your latest posts.' ) . '</p></div>';
+}