Changeset 31554 for trunk/src/wp-admin/includes/class-wp-filesystem-base.php

Timestamp:

02/26/2015 05:47:53 AM (11 years ago)

Author:

wonderboymusic

Message:

Don't call the size function count() as part of a test condition in loops. Compute the size beforehand, and not on each iteration.

Scrutinizer added a Performance label: these are the only violations.

See #30799.

File:

• trunk/src/wp-admin/includes/class-wp-filesystem-base.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-filesystem-base.php

@@ -372 +372 @@
         $attarray = preg_split('//', $mode);
 
-        for ($i=0; $i < count($attarray); $i++)
-           if ($key = array_search($attarray[$i], $legal))
+        for ( $i = 0, $c = count( $attarray ); $i < $c; $i++ ) {
+           if ($key = array_search($attarray[$i], $legal)) {
                $realmode .= $legal[$key];
+           }
+        }
 
         $mode = str_pad($realmode, 10, '-', STR_PAD_LEFT);