Changeset 31554 for trunk/src/wp-admin/includes/image-edit.php

Timestamp:

02/26/2015 05:47:53 AM (11 years ago)

Author:

wonderboymusic

Message:

Don't call the size function count() as part of a test condition in loops. Compute the size beforehand, and not on each iteration.

Scrutinizer added a Performance label: these are the only violations.

See #30799.

File:

• trunk/src/wp-admin/includes/image-edit.php (modified) (1 diff)

trunk/src/wp-admin/includes/image-edit.php

@@ -462 +462 @@
     if ( count($changes) > 1 ) {
         $filtered = array($changes[0]);
-        for ( $i = 0, $j = 1; $j < count($changes); $j++ ) {
+        for ( $i = 0, $j = 1, $c = count( $changes ); $j < $c; $j++ ) {
             $combined = false;
             if ( $filtered[$i]->type == $changes[$j]->type ) {