Changeset 31554 for trunk/src/wp-includes/functions.php

Timestamp:

02/26/2015 05:47:53 AM (9 years ago)

Author:

wonderboymusic

Message:

Don't call the size function count() as part of a test condition in loops. Compute the size beforehand, and not on each iteration.

Scrutinizer added a Performance label: these are the only violations.

See #30799.

File:

• trunk/src/wp-includes/functions.php (modified) (1 diff)

trunk/src/wp-includes/functions.php

@@ -1517 +1517 @@
         if ( $dir_perms != ( $dir_perms & ~umask() ) ) {
             $folder_parts = explode( '/', substr( $target, strlen( $target_parent ) + 1 ) );
-            for ( $i = 1; $i <= count( $folder_parts ); $i++ ) {
+            for ( $i = 1, $c = count( $folder_parts ); $i <= $c; $i++ ) {
                 @chmod( $target_parent . '/' . implode( '/', array_slice( $folder_parts, 0, $i ) ), $dir_perms );
             }