Changeset 31566 for trunk/src/wp-admin/includes/class-wp-press-this.php

Timestamp:

02/27/2015 02:49:05 AM (11 years ago)

Author:

azaozz

Message:

PressThis: accessibility enhancements:

• Add missing form labels.
• Add some screen-reader-text and aria-hidden attributes.
• Focus handling improvements.
• Change tagcloud-link into a button.
• Add missing ID attribute in tools.php.

Props afercia. Fixes #31449.

File:

• trunk/src/wp-admin/includes/class-wp-press-this.php (modified) (9 diffs)

trunk/src/wp-admin/includes/class-wp-press-this.php

@@ -538 +538 @@
                                 ?>
                                 <div id="post-formats-select">
+                                <fieldset><legend class="screen-reader-text"><?php _e( 'Post formats' ); ?></legend>
                                         <input type="radio" name="post_format" class="post-format" id="post-format-0" value="0" <?php checked( $post_format, '0' ); ?> />
                                         <label for="post-format-0" class="post-format-icon post-format-standard"><?php echo get_post_format_string( 'standard' ); ?></label>
@@ -551 +552 @@
                                          }
                                          ?>
+                                </fieldset>
                                 </div>
                                 <?php
@@ -570 +572 @@
                 if ( current_user_can( $taxonomy->cap->edit_terms ) ) {
                         ?>
-                        <button type="button" class="add-cat-toggle button-subtle">
-                                <span class="dashicons dashicons-plus"></span>
+                        <button type="button" class="add-cat-toggle button-subtle" aria-expanded="false">
+                                <span class="dashicons dashicons-plus"></span><span class="screen-reader-text"><?php _e( 'Toggle add category' ); ?></span>
                         </button>
                         <div class="add-category is-hidden">
@@ -593 +595 @@
                 <?php } ?>
                 <div class="categories-search-wrapper">
-                        <input id="categories-search" type="search" class="categories-search" placeholder="<?php esc_attr_e( 'Search categories' ) ?>">
+                        <input id="categories-search" type="search" class="categories-search" placeholder="<?php esc_attr_e( 'Search categories by name' ) ?>">
                         <label for="categories-search">
-                                <span class="dashicons dashicons-search"></span>
+                                <span class="dashicons dashicons-search"></span><span class="screen-reader-text"><?php _e( 'Search categories' ); ?></span>
                         </label>
                 </div>
-                <ul class="categories-select">
+                <ul class="categories-select" aria-label="<?php esc_attr_e( 'Categories' ); ?>">
                         <?php wp_terms_checklist( $post->ID, array( 'taxonomy' => 'category' ) ); ?>
                 </ul>
@@ -646 +648 @@
                 if ( $user_can_assign_terms ) {
                         ?>
-                        <p>
-                                <a href="#titlediv" class="tagcloud-link" id="link-post_tag"><?php echo $taxonomy->labels->choose_from_most_used; ?></a>
-                        </p>
+                        <button type="button" class="button-reset button-link tagcloud-link" id="link-post_tag"><?php echo $taxonomy->labels->choose_from_most_used; ?></button>
                         <?php
                 }
@@ -757 +757 @@
         <div id="scanbar" class="scan">
                 <form method="GET">
+                        <label for="url-scan" class="screen-reader-text"><?php _e( 'Scan site for content' ); ?></label>
                         <input type="url" name="u" id="url-scan" class="scan-url" value="" placeholder="<?php esc_attr_e( 'Enter a URL to scan' ) ?>" />
                         <input type="submit" name="url-scan-submit" id="url-scan-submit" class="scan-submit" value="<?php esc_attr_e( 'Scan' ) ?>" />
@@ -843 +844 @@
                                 <div class="setting-modal is-off-screen is-hidden">
                                         <button type="button" class="button-reset modal-close">
-                                                <span class="dashicons dashicons-arrow-left-alt2"></span><span class="setting-title"><?php _e( 'Post format' ); ?></span>
+                                                <span class="dashicons dashicons-arrow-left-alt2"></span>
+                                                <span class="setting-title" aria-hidden="true"><?php _e( 'Post format' ); ?></span>
+                                                <span class="screen-reader-text"><?php _e( 'Back to post options' ) ?></span>
                                         </button>
                                         <?php $this->post_formats_html( $post ); ?>
@@ -850 +853 @@
 
                         <div class="setting-modal is-off-screen is-hidden">
-                                <button type="button" class="button-reset modal-close"><span class="dashicons dashicons-arrow-left-alt2"></span><span class="setting-title"><?php _e( 'Categories' ); ?></span></button>
+                                <button type="button" class="button-reset modal-close">
+                                        <span class="dashicons dashicons-arrow-left-alt2"></span>
+                                        <span class="setting-title" aria-hidden="true"><?php _e( 'Categories' ); ?></span>
+                                        <span class="screen-reader-text"><?php _e( 'Back to post options' ) ?></span>
+                                </button>
                                 <?php $this->categories_html( $post ); ?>
                         </div>
 
                         <div class="setting-modal tags is-off-screen is-hidden">
-                                <button type="button" class="button-reset modal-close"><span class="dashicons dashicons-arrow-left-alt2"></span><span class="setting-title"><?php _e( 'Tags' ); ?></span></button>
+                                <button type="button" class="button-reset modal-close">
+                                        <span class="dashicons dashicons-arrow-left-alt2"></span>
+                                        <span class="setting-title" aria-hidden="true"><?php _e( 'Tags' ); ?></span>
+                                        <span class="screen-reader-text"><?php _e( 'Back to post options' ) ?></span>
+                                </button>
                                 <?php $this->tags_html( $post ); ?>
                         </div>
@@ -877 +888 @@
         <?php
 
-                // TODO: consider running "special" press-this hooks here?
-                // Maybe better so we don't output stuff accidentally added by plugins. Would probably prevent some errors.
                 do_action( 'admin_footer', '' );
                 do_action( 'admin_print_footer_scripts' );