Changeset 31596

Timestamp:

03/01/2015 11:28:00 PM (10 years ago)

Author:

azaozz

Message:

PressThis:

• Replace all %1$s and %2$s in suggestedHTML in case plugins repeat them.
• Fix docs typo, props kraftbj.

See #31373.

Location:

trunk/src/wp-admin

Files:

• includes/class-wp-press-this.php (modified) (1 diff)
• js/press-this.js (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-press-this.php

@@ -61 +61 @@
 
     /**
-     * Get the sources images and save them locally, fr posterity, unless we can't.
+     * Get the source's images and save them locally, for posterity, unless we can't.
      *
      * @since 4.2.0

trunk/src/wp-admin/js/press-this.js

@@ -209 +209 @@
             // Add a source attribution if there is one available.
             if ( url && siteConfig.suggestedHTML && ( ( title && __( 'newPost' ) !== title ) || siteName ) ) {
-                content += siteConfig.suggestedHTML.replace( '%1$s', encodeURI( url ) ).replace( '%2$s', ( title || siteName ) );
+                content += siteConfig.suggestedHTML.replace( /%1\$s/g, encodeURI( url ) ).replace( /%2\$s/g, ( title || siteName ) );
             }