WordPress.org

Make WordPress Core


Ignore:
Timestamp:
03/05/2015 01:14:15 PM (6 years ago)
Author:
boonebgorges
Message:

In PHPUnit test classes, parent::tearDown() should be the last thing done in tearDown() methods.

WP_UnitTestCase::tearDown() restores the test environment to the default
conditions, including rolling back the MySQL transaction that the test takes
place in, resetting globals, and unhooking test-specific filters. As such, all
teardown routines for specific tests should happen before the parent class's
tearDown() method is called. Failure to do so can cause database locks on
certain configurations, among other problems.

See #31537.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/canonical.php

    r30282 r31622  
    2424
    2525    public function tearDown() {
     26        wp_set_current_user( self::$old_current_user );
    2627        parent::tearDown();
    27         wp_set_current_user( self::$old_current_user );
    2828    }
    2929
Note: See TracChangeset for help on using the changeset viewer.