Changeset 31622 for trunk/tests/phpunit/tests/image/base.php

Timestamp:

03/05/2015 01:14:15 PM (10 years ago)

Author:

boonebgorges

Message:

In PHPUnit test classes, parent::tearDown() should be the last thing done in tearDown() methods.

WP_UnitTestCase::tearDown() restores the test environment to the default
conditions, including rolling back the MySQL transaction that the test takes
place in, resetting globals, and unhooking test-specific filters. As such, all
teardown routines for specific tests should happen before the parent class's
tearDown() method is called. Failure to do so can cause database locks on
certain configurations, among other problems.

See #31537.

File:

• trunk/tests/phpunit/tests/image/base.php (modified) (1 diff)

trunk/tests/phpunit/tests/image/base.php

@@ -23 +23 @@
      */
     public function tearDown() {
+        remove_filter( 'wp_image_editors', array( $this, 'setEngine' ), 10, 2 );
         parent::tearDown();
-
-        remove_filter( 'wp_image_editors', array( $this, 'setEngine' ), 10, 2 );
     }