Changeset 31632

Timestamp:

03/05/2015 09:02:42 PM (9 years ago)

Author:

wonderboymusic

Message:

In the modal state for Embed previews, only show the Title field when the preview fails.

Props johnbillion, wonderboymusic.
See #29476.

Location:

trunk/src/wp-includes/js/media

Files:

• views.js (modified) (3 diffs)
• views/embed/link.js (modified) (3 diffs)

trunk/src/wp-includes/js/media/views.js

@@ -4636 +4636 @@
                 shortcode: embed.string()
             }
-        } ).done( _.bind( this.renderoEmbed, this ) );
+        } )
+            .done( _.bind( this.renderoEmbed, this ) )
+            .fail( _.bind( this.renderFail, this ) );
+    },
+
+    renderFail: function () {
+        this.$( '.setting' ).hide().filter( '.title' ).show();
     },
 
@@ -4643 +4649 @@
             attr = {},
             opts = { silent: true };
+
+        this.$( '.setting' ).hide()
+            .filter( '.title' )[ html ? 'hide' : 'show' ]();
 
         if ( response && response.attr ) {
@@ -4665 +4674 @@
 
         this.spinner.hide();
-        
+
         this.$('.embed-container').show().find('.embed-preview').html( html );
     }

trunk/src/wp-includes/js/media/views/embed/link.js

@@ -59 +59 @@
                 shortcode: embed.string()
             }
-        } ).done( _.bind( this.renderoEmbed, this ) );
+        } )
+            .done( _.bind( this.renderoEmbed, this ) )
+            .fail( _.bind( this.renderFail, this ) );
+    },
+
+    renderFail: function () {
+        this.$( '.setting' ).hide().filter( '.title' ).show();
     },
 
@@ -66 +72 @@
             attr = {},
             opts = { silent: true };
+
+        this.$( '.setting' ).hide()
+            .filter( '.title' )[ html ? 'hide' : 'show' ]();
 
         if ( response && response.attr ) {
@@ -88 +97 @@
 
         this.spinner.hide();
-        
+
         this.$('.embed-container').show().find('.embed-preview').html( html );
     }