Changeset 31642

Timestamp:

03/06/2015 03:02:08 PM (10 years ago)

Author:

helen

Message:

Media: UI tweaks for Insert from URL.

"Title" field is now labeled as "Link Text", to reflect how it's actually used. It's also hidden whenever the embed is updating, to make it clearer that something is happening. Embed dimension fields are shown below the preview, much like image property fields are shown below.

fixes #29476, see #31139.

Location:

trunk/src/wp-includes

Files:

• js/media/views.js (modified) (3 diffs)
• js/media/views/embed/link.js (modified) (3 diffs)
• media-template.php (modified) (2 diffs)

trunk/src/wp-includes/js/media/views.js

@@ -4606 +4606 @@
         // clear out previous results
         this.$('.embed-container').hide().find('.embed-preview').html('');
+        this.$( '.setting' ).hide();
 
         // only proceed with embed if the field contains more than 6 characters
@@ -4642 +4643 @@
 
     renderFail: function () {
-        this.$( '.setting' ).hide().filter( '.title' ).show();
+        this.$( '.setting' ).hide().filter( '.link-text' ).show();
     },
 
@@ -4651 +4652 @@
 
         this.$( '.setting' ).hide()
-            .filter( '.title' )[ html ? 'hide' : 'show' ]();
+            .filter( '.link-text' )[ html ? 'hide' : 'show' ]();
 
         if ( response && response.attr ) {

trunk/src/wp-includes/js/media/views/embed/link.js

@@ -29 +29 @@
         // clear out previous results
         this.$('.embed-container').hide().find('.embed-preview').html('');
+        this.$( '.setting' ).hide();
 
         // only proceed with embed if the field contains more than 6 characters
@@ -65 +66 @@
 
     renderFail: function () {
-        this.$( '.setting' ).hide().filter( '.title' ).show();
+        this.$( '.setting' ).hide().filter( '.link-text' ).show();
     },
 
@@ -74 +75 @@
 
         this.$( '.setting' ).hide()
-            .filter( '.title' )[ html ? 'hide' : 'show' ]();
+            .filter( '.link-text' )[ html ? 'hide' : 'show' ]();
 
         if ( response && response.attr ) {

trunk/src/wp-includes/media-template.php

@@ -816 +816 @@
 
     <script type="text/html" id="tmpl-embed-link-settings">
-        <label class="setting title">
-            <span><?php _e( 'Title' ); ?></span>
-            <input type="text" class="alignment" data-setting="title" />
-        </label>
+        <label class="setting link-text">
+            <span><?php _e( 'Link Text' ); ?></span>
+            <input type="text" class="alignment" data-setting="link-text" />
+        </label>
+        <div class="embed-container" style="display: none;">
+            <div class="embed-preview"></div>
+        </div>
         <div class="embed-link-dimensions">
             <label class="setting width">
@@ -829 +832 @@
                 <input type="text" class="alignment" data-setting="height" />
             </label>
-        </div>
-        <div class="embed-container" style="display: none;">
-            <div class="embed-preview"></div>
         </div>
     </script>