Changeset 31645 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

03/06/2015 08:25:09 PM (10 years ago)

Author:

wonderboymusic

Message:

Introduce a function, wp_attachment_is( $type, $post = 0 ), to collapse the logic for determining whether an attachment is an image, audio, or video.

This is admittedly a first pass. There needs to be a generic handler for when any other type is passed, but for now it accepts the whitelist.

See #25275.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (2 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -2291 +2291 @@
     }
 
-    if ( 0 === strpos( $post['post_mime_type'], 'audio/' ) ) {
+    if ( wp_attachment_is( 'audio', $post['ID'] ) ) {
         $changed = false;
         $id3data = wp_get_attachment_metadata( $post['ID'] );
@@ -2449 +2449 @@
         $title = ''; // We no longer insert title tags into <img> tags, as they are redundant.
         $html = get_image_send_to_editor( $id, $caption, $title, $align, $url, (bool) $rel, $size, $alt );
-    } elseif ( 'video' === substr( $post->post_mime_type, 0, 5 ) || 'audio' === substr( $post->post_mime_type, 0, 5 )  ) {
+    } elseif ( wp_attachment_is( 'video', $post ) || wp_attachment_is( 'audio', $post )  ) {
         $html = stripslashes_deep( $_POST['html'] );
     }