Changeset 31681 for trunk/src/wp-admin/plugins.php

Timestamp:

03/09/2015 02:10:36 AM (11 years ago)

Author:

wonderboymusic

Message:

There are a few functions that have the ability to return false instead of a string, so the return value should be checked before being passed to functions that expect string.

These are trivial, but they clear out some Scrutinizer issues.

See #30799.

File:

• trunk/src/wp-admin/plugins.php (modified) (1 diff)

trunk/src/wp-admin/plugins.php

@@ -322 +322 @@
                     <?php submit_button( $data_to_delete ? __( 'Yes, Delete these files and data' ) : __( 'Yes, Delete these files' ), 'button', 'submit', false ); ?>
                 </form>
-                <form method="post" action="<?php echo esc_url(wp_get_referer()); ?>" style="display:inline;">
+                <?php
+                $referer = wp_get_referer();
+                ?>
+                <form method="post" action="<?php echo $referer ? esc_url( $referer ) : ''; ?>" style="display:inline;">
                     <?php submit_button( __( 'No, Return me to the plugin list' ), 'button', 'submit', false ); ?>
                 </form>