Changeset 31690

Timestamp:

03/09/2015 07:43:49 PM (10 years ago)

Author:

wonderboymusic

Message:

Replace flagrant instances of .html('') with .empty().

Props OriginalEXE, SergeyBiryukov.
Fixes #27034.

Location:

trunk/src

Files:

• wp-admin/js/edit-comments.js (modified) (1 diff)
• wp-admin/js/inline-edit-post.js (modified) (1 diff)
• wp-admin/js/media.js (modified) (1 diff)
• wp-admin/js/theme.js (modified) (1 diff)
• wp-admin/js/widgets.js (modified) (2 diffs)
• wp-includes/js/media/views.js (modified) (1 diff)
• wp-includes/js/media/views/embed/link.js (modified) (1 diff)
• wp-includes/js/plupload/handlers.js (modified) (1 diff)
• wp-includes/js/wp-ajax-response.js (modified) (1 diff)

trunk/src/wp-admin/js/edit-comments.js

@@ -352 +352 @@
         $('#replycontent').css('height', '').val('');
         $('#edithead input').val('');
-        $('.error', replyrow).html('').hide();
+        $('.error', replyrow).empty().hide();
         $('.spinner', replyrow).hide();
 

trunk/src/wp-admin/js/inline-edit-post.js

@@ -287 +287 @@
             if ( 'bulk-edit' === id ) {
                 $('table.widefat #bulk-edit').removeClass('inline-editor').hide().siblings('tr.hidden').remove();
-                $('#bulk-titles').html('');
+                $('#bulk-titles').empty();
                 $('#inlineedit').append( $('#bulk-edit') );
             } else {

trunk/src/wp-admin/js/media.js

@@ -33 +33 @@
 
         close: function() {
-            $('#find-posts-response').html('');
+            $('#find-posts-response').empty();
             $('#find-posts').hide();
             $( '.ui-find-overlay' ).hide();

trunk/src/wp-admin/js/theme.js

@@ -901 +901 @@
     render: function() {
         // Clear the DOM, please
-        this.$el.html( '' );
+        this.$el.empty();
 
         // If the user doesn't have switch capabilities

trunk/src/wp-admin/js/widgets.js

@@ -234 +234 @@
             drop: function(e,ui) {
                 ui.draggable.addClass('deleting');
-                $('#removing-widget').hide().children('span').html('');
+                $('#removing-widget').hide().children('span').empty();
             },
             over: function(e,ui) {
@@ -248 +248 @@
                 ui.draggable.removeClass('deleting');
                 $('div.widget-placeholder').show();
-                $('#removing-widget').hide().children('span').html('');
+                $('#removing-widget').hide().children('span').empty();
             }
         });

trunk/src/wp-includes/js/media/views.js

@@ -4605 +4605 @@
 
         // clear out previous results
-        this.$('.embed-container').hide().find('.embed-preview').html('');
+        this.$('.embed-container').hide().find('.embed-preview').empty();
         this.$( '.setting' ).hide();
 

trunk/src/wp-includes/js/media/views/embed/link.js

@@ -28 +28 @@
 
         // clear out previous results
-        this.$('.embed-container').hide().find('.embed-preview').html('');
+        this.$('.embed-container').hide().find('.embed-preview').empty();
         this.$( '.setting' ).hide();
 

trunk/src/wp-includes/js/plupload/handlers.js

@@ -449 +449 @@
 
         uploader.bind('FilesAdded', function( up, files ) {
-            $('#media-upload-error').html('');
+            $('#media-upload-error').empty();
             uploadStart();
 

trunk/src/wp-includes/js/wp-ajax-response.js

@@ -13 +13 @@
     },
     parseAjaxResponse: function( x, r, e ) { // 1 = good, 0 = strange (bad data?), -1 = you lack permission
-        var parsed = {}, re = jQuery('#' + r).html(''), err = '';
+        var parsed = {}, re = jQuery('#' + r).empty(), err = '';
 
         if ( x && typeof x == 'object' && x.getElementsByTagName('wp_ajax') ) {