Changeset 31696 for trunk/src/wp-admin/network/users.php

Timestamp:

03/10/2015 03:31:54 PM (10 years ago)

Author:

ocean90

Message:

Screen Options: Improve items per page option label.

Previously the label just said "Posts", "Pages", or "Comments". This was bad in terms of accessibility and internationalization because of missing context.
This change adds a default label "Number of items per page:" to WP_Screen->render_per_page_options() and removes all the existing one-word labels.

props afercia.
fixes #31349, #15576.

File:

• trunk/src/wp-admin/network/users.php (modified) (4 diffs)

trunk/src/wp-admin/network/users.php

@@ -30 +30 @@
         <p><?php _e( 'You have chosen to delete the user from all networks and sites.' ); ?></p>
     <?php endif; ?>
-    
+
     <form action="users.php?action=dodelete" method="post">
     <input type="hidden" name="dodelete" />
@@ -109 +109 @@
         <p><?php _e( 'Once you hit &#8220;Confirm Deletion&#8221;, the user will be permanently removed.' ); ?></p>
     <?php endif;
-    
+
     submit_button( __('Confirm Deletion'), 'delete' );
     ?>
     </form>
-    <?php
+    <?php
     return true;
 }
@@ -137 +137 @@
                 confirm_delete_users( $_POST['allusers'] );
                 echo '</div>';
-                require_once( ABSPATH . 'wp-admin/admin-footer.php' );
-            } else {
+                require_once( ABSPATH . 'wp-admin/admin-footer.php' );
+            } else {
                 wp_redirect( network_admin_url( 'users.php' ) );
             }
@@ -253 +253 @@
 $parent_file = 'users.php';
 
-add_screen_option( 'per_page', array('label' => _x( 'Users', 'users per page (screen options)' )) );
+add_screen_option( 'per_page' );
 
 get_current_screen()->add_help_tab( array(