Make WordPress Core


Ignore:
Timestamp:
03/10/2015 03:31:54 PM (9 years ago)
Author:
ocean90
Message:

Screen Options: Improve items per page option label.

Previously the label just said "Posts", "Pages", or "Comments". This was bad in terms of accessibility and internationalization because of missing context.
This change adds a default label "Number of items per page:" to WP_Screen->render_per_page_options() and removes all the existing one-word labels.

props afercia.
fixes #31349, #15576.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/network/users.php

    r31658 r31696  
    3030        <p><?php _e( 'You have chosen to delete the user from all networks and sites.' ); ?></p>
    3131    <?php endif; ?>
    32    
     32
    3333    <form action="users.php?action=dodelete" method="post">
    3434    <input type="hidden" name="dodelete" />
     
    109109        <p><?php _e( 'Once you hit &#8220;Confirm Deletion&#8221;, the user will be permanently removed.' ); ?></p>
    110110    <?php endif;
    111    
     111
    112112    submit_button( __('Confirm Deletion'), 'delete' );
    113113    ?>
    114114    </form>
    115     <?php
     115    <?php
    116116    return true;
    117117}
     
    137137                confirm_delete_users( $_POST['allusers'] );
    138138                echo '</div>';
    139                 require_once( ABSPATH . 'wp-admin/admin-footer.php' );
    140             } else {
     139                require_once( ABSPATH . 'wp-admin/admin-footer.php' );
     140            } else {
    141141                wp_redirect( network_admin_url( 'users.php' ) );
    142142            }
     
    253253$parent_file = 'users.php';
    254254
    255 add_screen_option( 'per_page', array('label' => _x( 'Users', 'users per page (screen options)' )) );
     255add_screen_option( 'per_page' );
    256256
    257257get_current_screen()->add_help_tab( array(
Note: See TracChangeset for help on using the changeset viewer.