Changeset 31732

Timestamp:

03/11/2015 10:40:56 PM (8 years ago)

Author:

azaozz

Message:

TinyMCE: initialize the floating toolbars on preinit so we can attach other events on init.
Props iseulde. Fixes #30619.

Location:

trunk/src/wp-includes/js/tinymce/plugins

Files:

• wpeditimage/plugin.js (modified) (5 diffs)
• wpview/plugin.js (modified) (2 diffs)

trunk/src/wp-includes/js/tinymce/plugins/wpeditimage/plugin.js

@@ -1 +1 @@
 /* global tinymce */
 tinymce.PluginManager.add( 'wpeditimage', function( editor ) {
-    var floatingToolbar, serializer,
+    var toolbar, serializer,
         each = tinymce.each,
         iOS = tinymce.Env.iOS;
@@ -60 +60 @@
     } );
 
+    editor.once( 'preinit', function() {
+        toolbar = editor.wp._createToolbar( [
+            'wp_img_alignleft',
+            'wp_img_aligncenter',
+            'wp_img_alignright',
+            'wp_img_alignnone',
+            'wp_img_edit',
+            'wp_img_remove'
+        ] );
+    } );
+
     editor.on( 'wptoolbar', function( event ) {
         if ( event.element.nodeName === 'IMG' && ! isPlaceholder( event.element ) ) {
-            event.toolbar = floatingToolbar;
+            event.toolbar = toolbar;
         }
     } );
@@ -78 +89 @@
                 }, 200 );
             } else {
-                floatingToolbar.hide();
+                toolbar.hide();
             }
         } );
@@ -545 +556 @@
         dom.addClass( editor.getBody(), captionClass );
 
-        if ( editor.wp._createToolbar ) {
-            floatingToolbar = editor.wp._createToolbar( [
-                'wp_img_alignleft',
-                'wp_img_aligncenter',
-                'wp_img_alignright',
-                'wp_img_alignnone',
-                'wp_img_edit',
-                'wp_img_remove'
-            ] );
-        }
-
         // Add caption field to the default image dialog
         editor.on( 'wpLoadImageForm', function( event ) {
@@ -868 +868 @@
             event.preventDefault();
 
-            if ( floatingToolbar ) {
-                floatingToolbar.reposition();
+            if ( toolbar ) {
+                toolbar.reposition();
             }
 

trunk/src/wp-includes/js/tinymce/plugins/wpview/plugin.js

@@ -241 +241 @@
             MutationObserver = window.MutationObserver || window.WebKitMutationObserver;
 
-        toolbar = editor.wp._createToolbar( [
-            'wp_view_edit',
-            'wp_view_remove'
-        ] );
-
         // When a view is selected, ensure content that is being pasted
         // or inserted is added to a text node (instead of the view).
@@ -674 +669 @@
     } );
 
+    editor.once( 'preinit', function() {
+        toolbar = editor.wp._createToolbar( [
+            'wp_view_edit',
+            'wp_view_remove'
+        ] );
+    } );
+
     editor.on( 'wptoolbar', function( event ) {
         if ( selected ) {