Changeset 31734

Timestamp:

03/11/2015 10:54:49 PM (11 years ago)

Author:

pento

Message:

Add emoji URL support, and Twemoji fallback for displaying slugs in wp-admin, when the browser doesn't natively support emoji.

Props pento, SergeyBiryukov and boonebgorges.

Fixes #31328

Location:

trunk

Files:

• src/wp-admin/js/inline-edit-post.js (modified) (4 diffs)
• src/wp-admin/js/inline-edit-tax.js (modified) (3 diffs)
• src/wp-admin/js/post.js (modified) (2 diffs)
• src/wp-admin/js/tags.js (modified) (1 diff)
• src/wp-includes/formatting.php (modified) (2 diffs)
• src/wp-includes/taxonomy.php (modified) (2 diffs)
• tests/phpunit/data/formatting/utf-8/entitized.txt (modified) (1 diff)
• tests/phpunit/data/formatting/utf-8/u-urlencoded.txt (modified) (1 diff)
• tests/phpunit/data/formatting/utf-8/urlencoded.txt (modified) (1 diff)
• tests/phpunit/data/formatting/utf-8/utf-8.txt (modified) (1 diff)
• tests/phpunit/tests/formatting/UrlEncodedToEntities.php (modified) (1 diff)
• tests/phpunit/tests/term.php (modified) (1 diff)

trunk/src/wp-admin/js/inline-edit-post.js

@@ -118 +118 @@
 
         edit : function(id) {
-                var t = this, fields, editRow, rowData, status, pageOpt, pageLevel, nextPage, pageLoop = true, nextLevel, cur_format, f;
+                var t = this, fields, editRow, rowData, status, pageOpt, pageLevel, nextPage, pageLoop = true, nextLevel, cur_format, f, val;
                 t.revert();
 
@@ -156 +156 @@
 
                 for ( f = 0; f < fields.length; f++ ) {
-                        $(':input[name="' + fields[f] + '"]', editRow).val( $('.'+fields[f], rowData).text() );
+                        val = $('.'+fields[f], rowData);
+                        // Deal with Twemoji
+                        val.find( 'img' ).replaceWith( function() { return this.alt; } );
+                        val = val.text();
+                        $(':input[name="' + fields[f] + '"]', editRow).val( val );
                 }
 
@@ -182 +186 @@
                 //flat taxonomies
                 $('.tags_input', rowData).each(function(){
-                        var terms = $(this).text(),
+                        var terms = $(this),
                                 taxname = $(this).attr('id').replace('_' + id, ''),
                                 textarea = $('textarea.tax_input_' + taxname, editRow),
                                 comma = inlineEditL10n.comma;
+
+                        terms.find( 'img' ).replaceWith( function() { return this.alt; } );
+                        terms = terms.text();
 
                         if ( terms ) {
@@ -266 +273 @@
                                                 $(inlineEditPost.what+id).siblings('tr.hidden').addBack().remove();
                                                 $('#edit-'+id).before(r).remove();
+                                                if ( WPEmoji ) {
+                                                        WPEmoji.parse( $( inlineEditPost.what + id ).get( 0 ) );
+                                                }
                                                 $(inlineEditPost.what+id).hide().fadeIn();
                                         } else {

trunk/src/wp-admin/js/inline-edit-tax.js

@@ -46 +46 @@
 
         edit : function(id) {
-                var editRow, rowData,
+                var editRow, rowData, val,
                         t = this;
                 t.revert();
@@ -59 +59 @@
                 $(t.what+id).hide().before(editRow).before('<tr class="hidden"></tr>');
 
-                $(':input[name="name"]', editRow).val( $('.name', rowData).text() );
-                $(':input[name="slug"]', editRow).val( $('.slug', rowData).text() );
+                val = $('.name', rowData);
+                val.find( 'img' ).replaceWith( function() { return this.alt; } );
+                val = val.text();
+                $(':input[name="name"]', editRow).val( val );
+
+                val = $('.slug', rowData);
+                val.find( 'img' ).replaceWith( function() { return this.alt; } );
+                val = val.text();
+                $(':input[name="slug"]', editRow).val( val );
 
                 $(editRow).attr('id', 'edit-'+id).addClass('inline-editor').show();
@@ -111 +118 @@
                                                 $( '#parent' ).find( 'option[value=' + option_value + ']' ).text( row.find( '.row-title' ).text() );
 
+                                                if ( WPEmoji ) {
+                                                        WPEmoji.parse( row.get( 0 ) );
+                                                }
+
                                                 row.hide().fadeIn();
                                         } else {

trunk/src/wp-admin/js/post.js

@@ -713 +713 @@
                         b = $('#edit-slug-buttons'),
                         revert_b = b.html(),
-                        full = $('#editable-post-name-full').html();
+                        full = $('#editable-post-name-full');
+
+                // Deal with Twemoji in the post-name
+                full.find( 'img' ).replaceWith( function() { return this.alt; } );
+                full = full.html();
 
                 $('#view-post-btn').hide();
@@ -737 +741 @@
                                         });
                                 }
+
+                                if ( WPEmoji ) {
+                                        WPEmoji.parse( box.get( 0 ) );
+                                }
+
                                 b.html(revert_b);
                                 real_slug.val(new_slug);

trunk/src/wp-admin/js/tags.js

@@ -50 +50 @@
                                 $( '.tags' ).prepend( res.responses[0].supplemental.parents ); // As the parent is not visible, Insert the version with Parent - Child - ThisTerm
 
+                        if ( WPEmoji ) {
+                                WPEmoji.parse( $( '.tags' ).get( 0 ) );
+                        }
+
                         $('.tags .no-items').remove();
 

trunk/src/wp-includes/formatting.php

@@ -786 +786 @@
                         $unicode_length++;
                 } else {
-                        if ( count( $values ) == 0 ) $num_octets = ( $value < 224 ) ? 2 : 3;
+                        if ( count( $values ) == 0 ) {
+                                if ( $value < 224 ) {
+                                        $num_octets = 2;
+                                } elseif ( $value < 240 ) {
+                                        $num_octets = 3;
+                                } else {
+                                        $num_octets = 4;
+                                }
+                        }
 
                         $values[] = $value;
@@ -793 +801 @@
                                 break;
                         if ( count( $values ) == $num_octets ) {
-                                if ($num_octets == 3) {
-                                        $unicode .= '%' . dechex($values[0]) . '%' . dechex($values[1]) . '%' . dechex($values[2]);
-                                        $unicode_length += 9;
-                                } else {
-                                        $unicode .= '%' . dechex($values[0]) . '%' . dechex($values[1]);
-                                        $unicode_length += 6;
+                                for ( $j = 0; $j < $num_octets; $j++ ) {
+                                        $unicode .= '%' . dechex( $values[ $j ] );
                                 }
+
+                                $unicode_length += $num_octets * 3;
 
                                 $values = array();

trunk/src/wp-includes/taxonomy.php

@@ -2880 +2880 @@
         $slug_provided = ! empty( $args['slug'] );
         if ( ! $slug_provided ) {
-                $_name = trim( $name );
-                $existing_term = get_term_by( 'name', $_name, $taxonomy );
-                if ( $existing_term ) {
-                        $slug = $existing_term->slug;
-                } else {
-                        $slug = sanitize_title( $name );
-                }
+                $slug = sanitize_title( $name );
         } else {
                 $slug = $args['slug'];
@@ -2911 +2905 @@
 
         // Terms with duplicate names are not allowed at the same level of a taxonomy hierarchy.
-        if ( $exists = term_exists( $slug, $taxonomy ) ) {
-                $existing_term = get_term( $exists['term_id'], $taxonomy );
-
-                if ( $name === $existing_term->name ) {
-
-                        if ( is_taxonomy_hierarchical( $taxonomy ) ) {
-                                $siblings = get_terms( $taxonomy, array( 'fields' => 'names', 'get' => 'all', 'parent' => $parent ) );
-                                if ( in_array( $name, $siblings ) ) {
-                                        return new WP_Error( 'term_exists', __( 'A term with the name and slug already exists with this parent.' ), $exists['term_id'] );
-                                }
-
-                        } else {
-                                return new WP_Error( 'term_exists', __( 'A term with the name and slug already exists in this taxonomy.' ), $exists['term_id'] );
+        if ( $existing_term = get_term_by( 'name', $name, $taxonomy ) ) {
+                if ( is_taxonomy_hierarchical( $taxonomy ) ) {
+                        $siblings = get_terms( $taxonomy, array( 'fields' => 'names', 'get' => 'all', 'parent' => $parent ) );
+                        if ( in_array( $name, $siblings ) ) {
+                                return new WP_Error( 'term_exists', __( 'A term with the name already exists with this parent.' ), $existing_term->term_id );
                         }
+                } else {
+                        return new WP_Error( 'term_exists', __( 'A term with the name already exists in this taxonomy.' ), $existing_term->term_id );
                 }
         }

trunk/tests/phpunit/data/formatting/utf-8/entitized.txt

@@ -4 +4 @@
 Björk Guðmundsdóttir
 宮崎　駿
+👍

trunk/tests/phpunit/data/formatting/utf-8/u-urlencoded.txt

@@ -4 +4 @@
 %u0042%u006A%u00F6%u0072%u006B%u0020%u0047%u0075%u00F0%u006D%u0075%u006E%u0064%u0073%u0064%u00F3%u0074%u0074%u0069%u0072
 %u5BAE%u5D0E%u3000%u99FF
+%u1F44D

trunk/tests/phpunit/data/formatting/utf-8/urlencoded.txt

@@ -4 +4 @@
 Bj%c3%b6rk Gu%c3%b0mundsd%c3%b3ttir
 %e5%ae%ae%e5%b4%8e%e3%80%80%e9%a7%bf
+%f0%9f%91%8d

trunk/tests/phpunit/data/formatting/utf-8/utf-8.txt

@@ -4 +4 @@
 Björk Guðmundsdóttir
 宮崎　駿
+👍

trunk/tests/phpunit/tests/formatting/UrlEncodedToEntities.php

@@ -9 +9 @@
          */
         function test_convert_urlencoded_to_entities( $u_urlencoded, $entity ) {
-                $this->assertEquals( $entity, preg_replace_callback('/\%u([0-9A-F]{4})/', '_convert_urlencoded_to_entities', $u_urlencoded ), $entity );
+                $this->assertEquals( $entity, preg_replace_callback('/\%u([0-9A-F]{4,5})/', '_convert_urlencoded_to_entities', $u_urlencoded ), $entity );
         }
 

trunk/tests/phpunit/tests/term.php

@@ -175 +175 @@
                 // Test existing term name with unique slug
                 $term1 = $this->factory->tag->create( array( 'name' => 'Bozo', 'slug' => 'bozo1' ) );
-                $this->assertFalse( is_wp_error( $term1 ) );
-                $this->assertTrue( empty($term1->errors ) );
+                $this->assertTrue( is_wp_error( $term1 ) );
+                $this->assertSame( 'term_exists', $term1->get_error_code() );
+                $this->assertEquals( $term->term_id, $term1->get_error_data() );
 
                 // Test an existing term name