Changeset 31783

Timestamp:

03/15/2015 12:19:12 PM (10 years ago)

Author:

pento

Message:

WPDB: HHVM doesn't support passing a DB link to mysqli_get_client_version(). While we usually pass a DB link to every ext/mysql and mysqli function call, we don't really need to do that here, as there's no way for the client library to change mid page load.

Another fun fact is that mysql_get_client_version() doesn't exist, but mysql_get_client_info() (along with `mysqli_get_client_info()') do. So, we're switching to them, in order to add a pleasing symmetry to the client version check.

Fixes #31644

File:

• trunk/src/wp-includes/wp-db.php (modified) (1 diff)

trunk/src/wp-includes/wp-db.php

@@ -2806 +2806 @@
                 }
                 if ( $this->use_mysqli ) {
-                    return mysqli_get_client_version( $this->dbh ) >= 50503;
+                    $client_version = mysqli_get_client_info();
                 } else {
-                    return mysql_get_client_version( $this->dbh ) >= 50503;
+                    $client_version = mysql_get_client_info();
                 }
+
+                return version_compare( $client_version, '5.5.3', '>=' );
         }