Changeset 31829 for trunk/src/wp-admin/includes/plugin-install.php

Timestamp:

03/19/2015 03:55:39 AM (10 years ago)

Author:

wonderboymusic

Message:

Replace array_shift() with reset() where appropriate for performance.

Props SergeyBiryukov.
Fixes #31259.

File:

• trunk/src/wp-admin/includes/plugin-install.php (modified) (2 diffs)

trunk/src/wp-admin/includes/plugin-install.php

@@ -305 +305 @@
             } else {
                 $key = array_keys( $installed_plugin );
-                $key = array_shift( $key ); //Use the first plugin regardless of the name, Could have issues for multiple-plugins in one directory if they share different version numbers
+                $key = reset( $key ); //Use the first plugin regardless of the name, Could have issues for multiple-plugins in one directory if they share different version numbers
                 $update_file = $api->slug . '/' . $key;
                 if ( version_compare($api->version, $installed_plugin[ $key ]['Version'], '=') ){
@@ -392 +392 @@
     if ( empty( $section ) || ! isset( $api->sections[ $section ] ) ) {
         $section_titles = array_keys( (array) $api->sections );
-        $section = array_shift( $section_titles );
+        $section = reset( $section_titles );
     }