Changeset 31864 for trunk/src/wp-includes/formatting.php

Timestamp:

03/23/2015 12:07:47 PM (5 years ago)

Author:

pento

Message:

Emoji: Gmail doesn't obey an <img>'s inline CSS height rule, transforming it to min-height. To avoid giant smiley faces everywhere, we're changing the height rule to max-height, which Gmail plays nicer with.

Props janhenckens.

Fixes #31719.

File:

• trunk/src/wp-includes/formatting.php (modified) (3 diffs)

trunk/src/wp-includes/formatting.php

@@ -2110 +2110 @@
     $src_url = apply_filters( 'smilies_src', includes_url( "images/smilies/$img" ), $img, site_url() );
 
-    return sprintf( '<img src="%s" alt="%s" class="wp-smiley" style="height: 1em;" />', esc_url( $src_url ), esc_attr( $smiley ) );
+    return sprintf( '<img src="%s" alt="%s" class="wp-smiley" style="max-height: 1em;" />', esc_url( $src_url ), esc_attr( $smiley ) );
 }
 
@@ -4201 +4201 @@
 
                         list( $char1, $char2 ) = str_split( $chars, 5 );
-                        $entity = '<img src="' . $cdn_url . $char1 . '-' . $char2 . $ext . '" class="wp-smiley" style="height: 1em;" />';
+                        $entity = '<img src="' . $cdn_url . $char1 . '-' . $char2 . $ext . '" class="wp-smiley" style="max-height: 1em;" />';
 
                         $content = str_replace( $flag, $entity, $content );
@@ -4216 +4216 @@
                     foreach ( $matches[1] as $emoji ) {
                         $char = str_replace( array( '&#x', ';'), '', $emoji );
-                        $entity = '<img src="' . $cdn_url . $char . $ext . '" class="wp-smiley" style="height: 1em;" />';
+                        $entity = '<img src="' . $cdn_url . $char . $ext . '" class="wp-smiley" style="max-height: 1em;" />';
 
                         $content = str_replace( $emoji, $entity, $content );