Changeset 31880 for trunk/src/wp-admin/includes/template.php

Timestamp:

03/25/2015 03:22:18 AM (10 years ago)

Author:

azaozz

Message:

Do not output empty name and id HTML attributes in get_submit_button().
Props afercia. Fixes #31749.

File:

• trunk/src/wp-admin/includes/template.php (modified) (1 diff)

trunk/src/wp-admin/includes/template.php

@@ -1909 +1909 @@
     }
 
-    $button = '<input type="submit" name="' . esc_attr( $name ) . '" id="' . esc_attr( $id ) . '" class="' . esc_attr( $class );
+    // Don't output empty name and id attributes.
+    $name_attr = $name ? ' name="' . esc_attr( $name ) . '"' : '';
+    $id_attr = $id ? ' id="' . esc_attr( $id ) . '"' : '';
+
+    $button = '<input type="submit"' . $name_attr . $id_attr . ' class="' . esc_attr( $class );
     $button .= '" value="' . esc_attr( $text ) . '" ' . $attributes . ' />';