Changeset 31887

Timestamp:

03/25/2015 05:54:50 PM (10 years ago)

Author:

ocean90

Message:

Avoid a PHP notice in wp_enqueue_script() if $handle is an array.

Calling wp_enqueue_script() with an array as the first argument is a "hidden feature" and should be avoided. Use dependencies instead.

props sorich87 for initial patch.
fixes #31636.
see #14488.

File:

• trunk/src/wp-includes/functions.wp-scripts.php (modified) (2 diffs)

trunk/src/wp-includes/functions.wp-scripts.php

@@ -210 +210 @@
  *
  * @since 2.6.0
-
+ *
  * @param string      $handle    Name of the script.
  * @param string|bool $src       Path to the script from the root directory of WordPress. Example: '/js/myscript.js'.
@@ -225 +225 @@
     _wp_scripts_maybe_doing_it_wrong( __FUNCTION__ );
 
-    $_handle = explode( '?', $handle );
-
-    if ( $src ) {
-        $wp_scripts->add( $_handle[0], $src, $deps, $ver );
-    }
-
-    if ( $in_footer ) {
-        $wp_scripts->add_data( $_handle[0], 'group', 1 );
+
+    if ( $src || $in_footer ) {
+        $_handle = explode( '?', $handle );
+
+        if ( $src ) {
+            $wp_scripts->add( $_handle[0], $src, $deps, $ver );
+        }
+
+        if ( $in_footer ) {
+            $wp_scripts->add_data( $_handle[0], 'group', 1 );
+        }
     }