Changeset 31895

Timestamp:

03/26/2015 01:22:01 AM (10 years ago)

Author:

boonebgorges

Message:

When saving post, ensure that non-hierarchical taxonomy input is defined before attempting to parse it.

Taxonomy metaboxes that are disabled for the current user are included in the
post.php markup, but do not contain the 'newtag' field, and so should be
skipped when looping through the metaboxes to avoid invoking String methods
on a variable of type undefined.

Props MikeNGarrett, A5hleyRich.
Fixes #30859.

File:

• trunk/src/wp-admin/js/tags-box.js (modified) (1 diff)

trunk/src/wp-admin/js/tags-box.js

@@ -113 +113 @@
 
             text = a ? $(a).text() : newtag.val();
+
+            if ( 'undefined' == typeof( text ) ) {
+                return false;
+            }
+
             tagsval = tags.val();
             newtags = tagsval ? tagsval + comma + text : text;