Changeset 31908

Timestamp:

03/26/2015 10:34:40 PM (9 years ago)

Author:

azaozz

Message:

Fix focusing in the plugin and theme editors. Update the help.
Props afercia, Cheffheid. Fixes #31415.

Location:

trunk/src/wp-admin

Files:

• js/common.js (modified) (3 diffs)
• plugin-editor.php (modified) (1 diff)
• theme-editor.php (modified) (1 diff)

trunk/src/wp-admin/js/common.js

@@ -471 +471 @@
 
         if ( e.keyCode == 27 ) { // escape key
+            // when pressing Escape: Opera 12 and 27 blur form fields, IE 8 clears them
+            e.preventDefault();
             $(el).data('tab-out', true);
             return;
@@ -486 +488 @@
         selEnd = el.selectionEnd;
         val = el.value;
-
-        try {
-            this.lastKey = 9; // not a standard DOM property, lastKey is to help stop Opera tab event. See blur handler below.
-        } catch(err) {}
 
         if ( document.selection ) {
@@ -508 +506 @@
     });
 
-    $('#newcontent').bind('blur.wpevent_InsertTab', function() {
-        if ( this.lastKey && 9 == this.lastKey )
-            this.focus();
-    });
-
     if ( pageInput.length ) {
         pageInput.closest('form').submit( function() {

trunk/src/wp-admin/plugin-editor.php

@@ -131 +131 @@
         '<p>' . __('Choose a plugin to edit from the menu in the upper right and click the Select button. Click once on any file name to load it in the editor, and make your changes. Don&#8217;t forget to save your changes (Update File) when you&#8217;re finished.') . '</p>' .
         '<p>' . __('The Documentation menu below the editor lists the PHP functions recognized in the plugin file. Clicking Look Up takes you to a web page about that particular function.') . '</p>' .
-        '<p id="newcontent-description">' . __('In the editing area the Tab key enters a tab character. To move below this area by pressing Tab, press the Esc key followed by the Tab key.') . '</p>' .
+        '<p id="newcontent-description">' . __( 'In the editing area the Tab key enters a tab character. To move below this area by pressing Tab, press the Esc key followed by the Tab key. In some cases the Esc key will need to be pressed twice before the Tab key will allow you to continue.' ) . '</p>' .
         '<p>' . __('If you want to make changes but don&#8217;t want them to be overwritten when the plugin is updated, you may be ready to think about writing your own plugin. For information on how to edit plugins, write your own from scratch, or just better understand their anatomy, check out the links below.') . '</p>' .
         ( is_network_admin() ? '<p>' . __('Any edits to files from this screen will be reflected on all sites in the network.') . '</p>' : '' )

trunk/src/wp-admin/theme-editor.php

@@ -28 +28 @@
     <p>' . __('Begin by choosing a theme to edit from the dropdown menu and clicking Select. A list then appears of all the template files. Clicking once on any file name causes the file to appear in the large Editor box.') . '</p>
     <p>' . __('For PHP files, you can use the Documentation dropdown to select from functions recognized in that file. Look Up takes you to a web page with reference material about that particular function.') . '</p>
-    <p id="newcontent-description">' . __('In the editing area the Tab key enters a tab character. To move below this area by pressing Tab, press the Esc key followed by the Tab key.') . '</p>
+    <p id="newcontent-description">' . __( 'In the editing area the Tab key enters a tab character. To move below this area by pressing Tab, press the Esc key followed by the Tab key. In some cases the Esc key will need to be pressed twice before the Tab key will allow you to continue.' ) . '</p>
     <p>' . __('After typing in your edits, click Update File.') . '</p>
     <p>' . __('<strong>Advice:</strong> think very carefully about your site crashing if you are live-editing the theme currently in use.') . '</p>