Changeset 31910

Timestamp:

03/27/2015 05:47:55 PM (11 years ago)

Author:

helen

Message:

Admin menu: Revert [31720] for swipe open/closed.

This is problematic on any device that uses swipe for history navigation, particularly iOS. It's also quite unrefined from an interaction point of view and would not be material for this release either way.

see #31187.

File:

• trunk/src/wp-admin/js/common.js (modified) (4 diffs)

trunk/src/wp-admin/js/common.js

@@ -706 +706 @@
         window.wpResponsive = {
                 init: function() {
-                        var self = this,
-                                x, y;
+                        var self = this;
 
                         // Modify functionality based on custom activate/deactivate event
@@ -722 +721 @@
                                 event.preventDefault();
                                 $wpwrap.toggleClass( 'wp-responsive-open' );
-                                if ( self.isOpen() ) {
+                                if ( $wpwrap.hasClass( 'wp-responsive-open' ) ) {
                                         $(this).find('a').attr( 'aria-expanded', 'true' );
                                         $( '#adminmenu a:first' ).focus();
@@ -730 +729 @@
                         } );
 
-                        $window.on( 'touchstart.wp-responsive', function( event ) {
-                                var touches = event.originalEvent.touches;
-
-                                if ( 1 !== touches.length ) {
-                                        return;
-                                }
-
-                                x = touches[0].clientX;
-                                y = touches[0].clientY;
-                        } );
-
-                        $window.on( 'touchend.wp-responsive', function( event ) {
-                                var touches = event.originalEvent.changedTouches,
-                                        isOpen = self.isOpen(),
-                                        distanceX;
-
-                                if ( 1 === touches.length && x && y ) {
-                                        if ( ( window.isRtl && isOpen ) || ( ! window.isRtl && ! isOpen ) ) {
-                                                distanceX = touches[0].clientX - x;
-                                        } else {
-                                                distanceX = x - touches[0].clientX;
-                                        }
-
-                                        if ( distanceX > 30 && distanceX > Math.abs( touches[0].clientY - y ) ) {
-                                                $( '#wp-admin-bar-menu-toggle' ).trigger( 'click' );
-                                        }
-                                }
-
-                                x = y = 0;
-                        } );
-
                         // Add menu events
                         $adminmenu.on( 'click.wp-responsive', 'li.wp-has-submenu > a', function( event ) {
@@ -782 +750 @@
                                 }
                         });
-                },
-
-                isOpen: function() {
-                        return $wpwrap.hasClass( 'wp-responsive-open' );
                 },