Changeset 31925 for trunk/src/wp-admin/js/press-this.js

Timestamp:

03/30/2015 03:08:30 AM (9 years ago)

Author:

azaozz

Message:

Press This: fix accessibility for the post options "sidebar". Fix size of the Add Category button.
Part props afercis, joedolson. Fixes #31575.

File:

• trunk/src/wp-admin/js/press-this.js (modified) (4 diffs)

trunk/src/wp-admin/js/press-this.js

@@ -489 +489 @@
             sidebarIsOpen = true;
 
-            $( '.options-open, .press-this-actions, #scanbar' ).addClass( isHidden );
-            $( '.options-close, .options-panel-back' ).removeClass( isHidden );
+            $( '.options' ).removeClass( 'closed' ).addClass( 'open' );
+            $( '.press-this-actions, #scanbar' ).addClass( isHidden );
+            $( '.options-panel-back' ).removeClass( isHidden );
 
             $( '.options-panel' ).removeClass( offscreenHidden )
-                .one( 'transitionend', function() {
+                .one( transitionEndEvent, function() {
                     $( '.post-option:first' ).focus();
                 } );
@@ -501 +502 @@
             sidebarIsOpen = false;
 
-            $( '.options-close, .options-panel-back' ).addClass( isHidden );
-            $( '.options-open, .press-this-actions, #scanbar' ).removeClass( isHidden );
+            $( '.options' ).removeClass( 'open' ).addClass( 'closed' );
+            $( '.options-panel-back' ).addClass( isHidden );
+            $( '.press-this-actions, #scanbar' ).removeClass( isHidden );
 
             $( '.options-panel' ).addClass( isOffScreen )
-                .one( 'transitionend', function() {
+                .one( transitionEndEvent, function() {
                     $( this ).addClass( isHidden );
                     // Reset to options list
@@ -621 +623 @@
             monitorCatList();
 
-            $( '.options-open' ).on( 'click.press-this', openSidebar );
-            $( '.options-close' ).on( 'click.press-this', closeSidebar );
+            $( '.options' ).on( 'click.press-this', function() {
+                if ( $( this ).hasClass( 'open' ) ) {
+                    closeSidebar();
+                } else {
+                    openSidebar();
+                }
+            });
 
             // Close the sidebar when focus moves outside of it.
@@ -633 +640 @@
                         ( node.nodeName === 'BODY' ||
                             ( ! $node.closest( '.options-panel' ).length &&
-                            ! $node.closest( '.options-open' ).length ) ) ) {
+                            ! $node.closest( '.options' ).length ) ) ) {
 
                         closeSidebar();