Changeset 31973 for trunk/src/wp-admin/nav-menus.php

Timestamp:

04/01/2015 10:05:17 PM (11 years ago)

Author:

helen

Message:

Admin notices: Make (most) core notices dismissible.

These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.

File:

• trunk/src/wp-admin/nav-menus.php (modified) (9 diffs)

trunk/src/wp-admin/nav-menus.php

@@ -232 +232 @@
 
         if ( is_nav_menu_item( $menu_item_id ) && wp_delete_post( $menu_item_id, true ) )
-            $messages[] = '<div id="message" class="updated"><p>' . __('The menu item has been successfully deleted.') . '</p></div>';
+            $messages[] = '<div id="message" class="updated notice is-dismissible"><p>' . __('The menu item has been successfully deleted.') . '</p></div>';
         break;
 
@@ -249 +249 @@
 
         if ( is_wp_error( $deletion ) )
-            $messages[] = '<div id="message" class="error"><p>' . $deletion->get_error_message() . '</p></div>';
+            $messages[] = '<div id="message" class="error notice is-dismissible"><p>' . $deletion->get_error_message() . '</p></div>';
         else
-            $messages[] = '<div id="message" class="updated"><p>' . __( 'The menu has been successfully deleted.' ) . '</p></div>';
+            $messages[] = '<div id="message" class="updated notice is-dismissible"><p>' . __( 'The menu has been successfully deleted.' ) . '</p></div>';
         break;
 
@@ -262 +262 @@
             $deletion = wp_delete_nav_menu( $menu_id_to_delete );
             if ( is_wp_error( $deletion ) ) {
-                $messages[] = '<div id="message" class="error"><p>' . $deletion->get_error_message() . '</p></div>';
+                $messages[] = '<div id="message" class="error notice is-dismissible"><p>' . $deletion->get_error_message() . '</p></div>';
                 $deletion_error = true;
             }
@@ -268 +268 @@
 
         if ( empty( $deletion_error ) )
-            $messages[] = '<div id="message" class="updated"><p>' . __( 'Selected menus have been successfully deleted.' ) . '</p></div>';
+            $messages[] = '<div id="message" class="updated notice is-dismissible"><p>' . __( 'Selected menus have been successfully deleted.' ) . '</p></div>';
         break;
 
@@ -297 +297 @@
 
                 if ( is_wp_error( $_nav_menu_selected_id ) ) {
-                    $messages[] = '<div id="message" class="error"><p>' . $_nav_menu_selected_id->get_error_message() . '</p></div>';
+                    $messages[] = '<div id="message" class="error notice is-dismissible"><p>' . $_nav_menu_selected_id->get_error_message() . '</p></div>';
                 } else {
                     $_menu_object = wp_get_nav_menu_object( $_nav_menu_selected_id );
@@ -328 +328 @@
                 }
             } else {
-                $messages[] = '<div id="message" class="error"><p>' . __( 'Please enter a valid menu name.' ) . '</p></div>';
+                $messages[] = '<div id="message" class="error notice is-dismissible"><p>' . __( 'Please enter a valid menu name.' ) . '</p></div>';
             }
 
@@ -338 +338 @@
             $menu_title = trim( esc_html( $_POST['menu-name'] ) );
             if ( ! $menu_title ) {
-                $messages[] = '<div id="message" class="error"><p>' . __( 'Please enter a valid menu name.' ) . '</p></div>';
+                $messages[] = '<div id="message" class="error notice is-dismissible"><p>' . __( 'Please enter a valid menu name.' ) . '</p></div>';
                 $menu_title = $_menu_object->name;
             }
@@ -346 +346 @@
                 if ( is_wp_error( $_nav_menu_selected_id ) ) {
                     $_menu_object = $_nav_menu_selected_id;
-                    $messages[] = '<div id="message" class="error"><p>' . $_nav_menu_selected_id->get_error_message() . '</p></div>';
+                    $messages[] = '<div id="message" class="error notice is-dismissible"><p>' . $_nav_menu_selected_id->get_error_message() . '</p></div>';
                 } else {
                     $_menu_object = wp_get_nav_menu_object( $_nav_menu_selected_id );
@@ -375 +375 @@
             set_theme_mod( 'nav_menu_locations', $menu_locations );
 
-            $messages[] = '<div id="message" class="updated"><p>' . __( 'Menu locations updated.' ) . '</p></div>';
+            $messages[] = '<div id="message" class="updated notice is-dismissible"><p>' . __( 'Menu locations updated.' ) . '</p></div>';
         }
         break;