Changeset 31983 for trunk/src/wp-includes/class-wp-xmlrpc-server.php

Timestamp:

04/02/2015 03:48:41 PM (9 years ago)

Author:

johnbillion

Message:

Correctly set the post author in wp_xmlrpc_server::mw_editPost() when the current user is not the author of the post.

Props redsweater, markoheijnen, DrewAPicture
Fixes #24916

File:

• trunk/src/wp-includes/class-wp-xmlrpc-server.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -4757 +4757 @@
 
         // Only set the post_author if one is set.
-        if ( isset($content_struct['wp_author_id']) && ($user->ID != $content_struct['wp_author_id']) ) {
-            switch ( $post_type ) {
-                case 'post':
-                    if ( !current_user_can('edit_others_posts') )
-                        return new IXR_Error( 401, __( 'You are not allowed to change the post author as this user.' ) );
-                    break;
-                case 'page':
-                    if ( !current_user_can('edit_others_pages') )
-                        return new IXR_Error( 401, __( 'You are not allowed to change the page author as this user.' ) );
-                    break;
-                default:
-                    return new IXR_Error( 401, __( 'Invalid post type' ) );
+        if ( isset( $content_struct['wp_author_id'] ) ) {
+            // Check permissions if attempting to switch author to or from another user.
+            if ( $user->ID != $content_struct['wp_author_id'] || $user->ID != $post_author ) {
+                switch ( $post_type ) {
+                    case 'post':
+                        if ( ! current_user_can( 'edit_others_posts' ) ) {
+                            return new IXR_Error( 401, __( 'You are not allowed to change the post author as this user.' ) );
+                        }
+                        break;
+                    case 'page':
+                        if ( ! current_user_can( 'edit_others_pages' ) ) {
+                            return new IXR_Error( 401, __( 'You are not allowed to change the page author as this user.' ) );
+                        }
+                        break;
+                    default:
+                        return new IXR_Error( 401, __( 'Invalid post type' ) );
+                        break;
+                }
+                $post_author = $content_struct['wp_author_id'];
             }
-            $post_author = $content_struct['wp_author_id'];
         }