Changeset 31996 for trunk/src/wp-admin/options-general.php

Timestamp:

04/03/2015 04:51:18 AM (8 years ago)

Author:

helen

Message:

Spinners: Toggle a class instead of show/hide.

Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.

File:

• trunk/src/wp-admin/options-general.php (modified) (1 diff)

trunk/src/wp-admin/options-general.php

@@ -61 +61 @@
         $("input[name='date_format_custom'], input[name='time_format_custom']").change( function() {
             var format = $(this);
-            format.siblings('.spinner').css('display', 'inline-block'); // show(); can't be used here
+            format.siblings( '.spinner' ).addClass( 'is-active' );
             $.post(ajaxurl, {
                     action: 'date_format_custom' == format.attr('name') ? 'date_format' : 'time_format',
                     date : format.val()
-                }, function(d) { format.siblings('.spinner').hide(); format.siblings('.example').text(d); } );
+                }, function(d) { format.siblings( '.spinner' ).removeClass( 'is-active' ); format.siblings('.example').text(d); } );
         });