Changeset 32079

Timestamp:

04/08/2015 05:10:53 PM (10 years ago)

Author:

boonebgorges

Message:

Don't allow whitespace-only image captions from the Media modal.

Captions containing only whitespace trick image_add_caption() into thinking
a caption is required, but the empty caption text confuses wpeditimage into
stripping the 'align' class specified by the user.

Fixes #21848.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (1 diff)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -2446 +2446 @@
         $size = isset( $attachment['image-size'] ) ? $attachment['image-size'] : 'medium';
         $alt = isset( $attachment['image_alt'] ) ? $attachment['image_alt'] : '';
+
+        // No whitespace-only captions.
         $caption = isset( $attachment['post_excerpt'] ) ? $attachment['post_excerpt'] : '';
+        if ( '' === trim( $caption ) ) {
+            $caption = '';
+        }
+
         $title = ''; // We no longer insert title tags into <img> tags, as they are redundant.
         $html = get_image_send_to_editor( $id, $caption, $title, $align, $url, (bool) $rel, $size, $alt );