WordPress.org

Make WordPress Core

Changeset 32080


Ignore:
Timestamp:
04/08/2015 05:26:05 PM (4 years ago)
Author:
jorbin
Message:

Fix logic for details based shiny updates.

This fixes two problems. TB seems to sometimes strip window.location.search variables after tb ones, so we need to move it forward. Also fixes logic error.

See #31739

Location:
trunk/src/wp-admin
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/js/updates.js

    r32067 r32080  
    482482            $.support.postMessage = !! window.postMessage;
    483483
    484             if ( $.support.postMessage === false || target === null || window.location.search.indexOf( 'parent=update-core' ) === -1 )
     484            if ( $.support.postMessage === false || target === null || window.location.search.indexOf( 'parent=update-core' ) !== -1 )
    485485                return;
    486486
  • trunk/src/wp-admin/update-core.php

    r32067 r32080  
    265265        }
    266266
    267         $details_url = self_admin_url('plugin-install.php?tab=plugin-information&plugin=' . $plugin_data->update->slug . '&section=changelog&TB_iframe=true&width=640&height=662&parent=update-core');
     267        $details_url = self_admin_url('plugin-install.php?tab=plugin-information&parent=update-core&plugin=' . $plugin_data->update->slug . '&section=changelog&TB_iframe=true&width=640&height=662');
    268268        $details_text = sprintf(__('View version %1$s details'), $plugin_data->update->new_version);
    269269        $details = sprintf('<a href="%1$s" class="thickbox" title="%2$s">%3$s</a>.', esc_url($details_url), esc_attr($plugin_data->Name), $details_text);
Note: See TracChangeset for help on using the changeset viewer.