WordPress.org

Make WordPress Core

Changeset 32101


Ignore:
Timestamp:
04/09/2015 08:34:10 PM (4 years ago)
Author:
helen
Message:

Media: Bring back spinners, now without bouncing select elements.

props afercia for the initial patch.
see #22839, #30725.

Location:
trunk/src/wp-includes
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/css/media-views.css

    r32073 r32101  
    15101510    -webkit-background-size: 20px 20px;
    15111511    background-size: 20px 20px;
    1512     display: none;
     1512    float: right;
     1513    display: inline-block;
     1514    visibility: hidden;
    15131515    opacity: 0.7;
    15141516    filter: alpha(opacity=70);
     
    15161518    height: 20px;
    15171519    margin: 0;
     1520    vertical-align: middle;
     1521}
     1522
     1523.media-frame .spinner.is-active {
     1524    visibility: visible;
    15181525}
    15191526
     
    15371544
    15381545.attachment-details .settings-save-status .spinner {
    1539     margin: 0 5px 0;
     1546    margin-left: 5px;
    15401547}
    15411548
     
    15451552}
    15461553
    1547 .attachment-details.save-waiting .settings-save-status .spinner,
     1554.attachment-details.save-waiting .settings-save-status .spinner {
     1555    visibility: visible;
     1556}
     1557
    15481558.attachment-details.save-complete .settings-save-status .saved {
    15491559    display: block;
     
    17881798
    17891799.media-frame .embed-loading .embed-url .spinner {
    1790     display: block;
     1800    visibility: visible;
    17911801}
    17921802
  • trunk/src/wp-includes/js/media/views.js

    r31960 r32101  
    45474547        }
    45484548
    4549         this.spinner.show();
    4550 
    45514549        this.fetch();
    45524550    }, 600 ),
     
    46074605            this.model.unset( 'width', opts );
    46084606        }
    4609 
    4610         this.spinner.hide();
    46114607
    46124608        this.$('.embed-container').show().find('.embed-preview').html( html );
     
    74647460        if ( ! this.spinnerTimeout ) {
    74657461            this.spinnerTimeout = _.delay(function( $el ) {
    7466                 $el.show();
     7462                $el.addClass( 'is-active' );
    74677463            }, this.delay, this.$el );
    74687464        }
     
    74727468
    74737469    hide: function() {
    7474         this.$el.hide();
     7470        this.$el.removeClass( 'is-active' );
    74757471        this.spinnerTimeout = clearTimeout( this.spinnerTimeout );
    74767472
  • trunk/src/wp-includes/js/media/views/embed/link.js

    r31935 r32101  
    3434            return;
    3535        }
    36 
    37         this.spinner.show();
    3836
    3937        this.fetch();
     
    9694        }
    9795
    98         this.spinner.hide();
    99 
    10096        this.$('.embed-container').show().find('.embed-preview').html( html );
    10197    }
  • trunk/src/wp-includes/js/media/views/spinner.js

    r31935 r32101  
    1818        if ( ! this.spinnerTimeout ) {
    1919            this.spinnerTimeout = _.delay(function( $el ) {
    20                 $el.show();
     20                $el.addClass( 'is-active' );
    2121            }, this.delay, this.$el );
    2222        }
     
    2626
    2727    hide: function() {
    28         this.$el.hide();
     28        this.$el.removeClass( 'is-active' );
    2929        this.spinnerTimeout = clearTimeout( this.spinnerTimeout );
    3030
Note: See TracChangeset for help on using the changeset viewer.