Changeset 32106 for trunk/src/wp-admin/includes/class-wp-press-this.php

Timestamp:

04/10/2015 09:07:42 PM (11 years ago)

Author:

azaozz

Message:

Press This: check the bookmarklet version and add the update notice from PHP.
Fixes #31942.

File:

• trunk/src/wp-admin/includes/class-wp-press-this.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-press-this.php

@@ -15 +15 @@
 class WP_Press_This {
 
+        // Used to trigger the bookmarklet update notice.
+        public $version = 8;
+
         private $images = array();
 
@@ -39 +42 @@
         public function site_settings() {
                 return array(
-                        /*
-                         * Used to trigger the bookmarklet update notice. Needs to be set here and in
-                         * get_shortcut_link() in wp-includes/link-template.php.
-                         */
-                        'version' => '8',
-
                         /**
                          * Filter whether or not Press This should redirect the user in the parent window upon save.
@@ -1324 +1321 @@
                 <div class="editor-wrapper">
                         <div class="alerts" role="alert" aria-live="assertive" aria-relevant="all" aria-atomic="true">
-                                <p class="alert is-notice is-hidden should-upgrade-bookmarklet">
-                                        <?php printf( __( 'You should upgrade <a href="%s" target="_blank">your bookmarklet</a> to the latest version!' ), admin_url( 'tools.php' ) ); ?>
-                                </p>
+                                <?php
+
+                                if ( empty( $data['v'] ) || $this->version > $data['v'] ) {
+                                        ?>
+                                        <p class="alert is-notice">
+                                                <?php printf( __( 'You should upgrade <a href="%s" target="_blank">your bookmarklet</a> to the latest version!' ), admin_url( 'tools.php' ) ); ?>
+                                        </p>
+                                        <?php
+                                }
+
+                                ?>
                         </div>