Changeset 32134

Timestamp:

04/15/2015 04:32:03 PM (11 years ago)

Author:

ocean90

Message:

Customizer: Escape theme preview URLs.

props johnbillion, ocean90.
see #31896.

Location:

trunk/src

Files:

• wp-admin/includes/theme.php (modified) (2 diffs)
• wp-includes/class-wp-customize-control.php (modified) (1 diff)

trunk/src/wp-admin/includes/theme.php

@@ -512 +512 @@
  */
 function customize_themes_print_templates() {
+        $preview_url = esc_url( add_query_arg( 'theme', '__THEME__' ) ); // Token because esc_url() strips curly braces.
+        $preview_url = str_replace( '__THEME__', '{{ data.id }}', $preview_url );
         ?>
         <script type="text/html" id="tmpl-customize-themes-details-view">
@@ -551 +553 @@
                                 <div class="theme-actions">
                                         <div class="inactive-theme">
-                                                <a href="<?php echo add_query_arg( 'theme', '{{ data.id }}' ); ?>" target="_top" class="button button-primary"><?php _e( 'Live Preview' ); ?></a>
+                                                <a href="<?php echo $preview_url; ?>" target="_top" class="button button-primary"><?php _e( 'Live Preview' ); ?></a>
                                         </div>
                                 </div>

trunk/src/wp-includes/class-wp-customize-control.php

@@ -1244 +1244 @@
         public function content_template() {
                 $current_url = set_url_scheme( 'http://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'] );
-                $preview_url = add_query_arg( 'theme', '{{ data.theme.id }}', $current_url );
+                $preview_url = esc_url( add_query_arg( 'theme', '__THEME__', $current_url ) ); // Token because esc_url() strips curly braces.
+                $preview_url = str_replace( '__THEME__', '{{ data.theme.id }}', $preview_url );
                 ?>
                 <div class="theme" tabindex="0" data-preview-url="<?php echo esc_attr( $preview_url ); ?>" aria-describedby="{{ data.theme.id }}-action {{ data.theme.id }}-name">