Changeset 32139

Timestamp:

04/16/2015 11:59:01 PM (10 years ago)

Author:

boonebgorges

Message:

During PHPUnit tests, don't autodetect permalink structure during WP installation.

The unit tests expect non-pretty permalinks, so there's no benefit to detecting
the ability to have pretty permalinks. Moreover, the wp_remote_get() call can
cause installation to hang when there are DNS issues.

Fixes #31994.

Location:

trunk/tests/phpunit/includes

Files:

• functions.php (modified) (1 diff)
• install.php (modified) (1 diff)

trunk/tests/phpunit/includes/functions.php

@@ -104 +104 @@
     }
 }
+
+/**
+ * Set a permalink structure.
+ *
+ * Hooked as a callback to the 'populate_options' action, we use this function to set a permalink structure during
+ * `wp_install()`, so that WP doesn't attempt to do a time-consuming remote request.
+ *
+ * @since 4.2.0
+ */
+function _set_default_permalink_structure_for_tests() {
+    update_option( 'permalink_structure', '/%year%/%monthnum%/%day%/%postname%/' );
+}

trunk/tests/phpunit/includes/install.php

@@ -45 +45 @@
 }
 
+// Prefill a permalink structure so that WP doesn't try to determine one itself.
+add_action( 'populate_options', '_set_default_permalink_structure_for_tests' );
+
 wp_install( WP_TESTS_TITLE, 'admin', WP_TESTS_EMAIL, true, null, 'password' );
+
+// Delete dummy permalink structure, as prefilled above.
+if ( ! is_multisite() ) {
+    delete_option( 'permalink_structure' );
+}
+remove_action( 'populate_options', '_set_default_permalink_structure_for_tests' );
 
 if ( $multisite ) {