Make WordPress Core


Ignore:
Timestamp:
04/21/2015 05:10:11 AM (9 years ago)
Author:
pento
Message:

WPDB: When deciding if a query needs extra sanity checking based on collation, we can quickly return if it's a query that will never return user data.

Fixes #32029.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/db/charset.php

    r32162 r32232  
    506506            $value[2] = "SELECT * FROM $this_table_name";
    507507            $value[3] = "DROP TABLE IF EXISTS $this_table_name";
     508            $value[4] = array(
     509                "SHOW FULL TABLES LIKE $this_table_name",
     510                "DESCRIBE $this_table_name",
     511                "DESC $this_table_name",
     512                "EXPLAIN SELECT * FROM $this_table_name",
     513            );
    508514        }
    509515        unset( $value );
     
    517523     * @ticket 21212
    518524     */
    519     function test_table_collation_check( $create, $expected, $query, $drop ) {
     525    function test_table_collation_check( $create, $expected, $query, $drop, $always_true ) {
    520526        self::$_wpdb->query( $drop );
    521527
     
    525531        $this->assertEquals( $expected, $return );
    526532
     533        foreach( $always_true as $true_query ) {
     534            $return = self::$_wpdb->check_safe_collation( $true_query );
     535            $this->assertTrue( $return );
     536        }
     537
    527538        self::$_wpdb->query( $drop );
    528539    }
Note: See TracChangeset for help on using the changeset viewer.