Changeset 32274

Timestamp:

04/23/2015 11:51:18 AM (10 years ago)

Author:

pento

Message:

WPDB: When sanity checking a string by sending it to MySQL for conversion checks, the incorrect data structure was being returned from wpdb::strip_invalid_text(), causing all write queries to fail for some character sets when the query contained non-ASCII characters.

Merge of [32261] to the 3.8 branch.

See #32051.

Location:

branches/3.8

Files:

• src/wp-includes/wp-db.php (modified) (1 diff)
• tests/phpunit/tests/db/charset.php (modified) (1 diff)

branches/3.8/src/wp-includes/wp-db.php

@@ -2104 +2104 @@
                     // Split the CONVERT() calls by charset, so we can make sure the connection is right
                     $queries[ $value['charset'] ][ $col ] = $this->prepare( "CONVERT( %s USING {$value['charset']} )", $value['value'] );
+                    unset( $data[ $col ]['db'] );
                 }
             }

branches/3.8/tests/phpunit/tests/db/charset.php

@@ -56 +56 @@
             ),
             'koi8r' => array(
-                // koi8r is a character set that needs to be checked in MySQL
                 'charset'  => 'koi8r',
                 'value'    => "\xfdord\xf2ress",
                 'expected' => "\xfdord\xf2ress",
-                'db'       => true
             ),
             'hebrew' => array(
-                // hebrew needs to be checked in MySQL, too
                 'charset'  => 'hebrew',
                 'value'    => "\xf9ord\xf7ress",
                 'expected' => "\xf9ord\xf7ress",
-                'db'       => true
+            ),
+            'cp1251' => array(
+                'charset'  => 'cp1251',
+                'value'    => "\xd8ord\xd0ress",
+                'expected' => "\xd8ord\xd0ress",
+            ),
+            'tis620' => array(
+                'charset'  => 'tis620',
+                'value'    => "\xccord\xe3ress",
+                'expected' => "\xccord\xe3ress",
             ),
             'false' => array(