Changeset 32326 for trunk/src/wp-includes/taxonomy.php

Timestamp:

04/29/2015 12:55:29 PM (10 years ago)

Author:

boonebgorges

Message:

Improve performance of loop detection in _get_term_children().

Using an array keyed by term_id allows us to use isset() rather than the
slower in_array(). In addition, it lets us avoid the use of wp_list_pluck()
on large arrays, and helps us to avoid arrays that are unnecessarily large due
to duplicate entries.

Fixes #32144 for trunk.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (4 diffs)

trunk/src/wp-includes/taxonomy.php

@@ -3927 +3927 @@
  * @param array  $ancestors Term ancestors that have already been identified. Passed by reference, to keep track of
  *                          found terms when recursing the hierarchy. The array of located ancestors is used to prevent
- *                          infinite recursion loops.
+ *                          infinite recursion loops. For performance, term_ids are used as array keys, with 1 as value.
  * @return array The subset of $terms that are descendants of $term_id.
  */
@@ -3943 +3943 @@
     // Include the term itself in the ancestors array, so we can properly detect when a loop has occurred.
     if ( empty( $ancestors ) ) {
-        $ancestors[] = $term_id;
+        $ancestors[ $term_id ] = 1;
     }
 
@@ -3956 +3956 @@
 
         // Don't recurse if we've already identified the term as a child - this indicates a loop.
-        if ( in_array( $term->term_id, $ancestors ) ) {
+        if ( isset( $ancestors[ $term->term_id ] ) ) {
             continue;
         }
@@ -3969 +3969 @@
                 continue;
 
-            if ( $use_id ) {
-                $ancestors = array_merge( $ancestors, $term_list );
-            } else {
-                $ancestors = array_merge( $ancestors, wp_list_pluck( $term_list, 'term_id' ) );
-            }
+            $ancestors[ $term->term_id ] = 1;;
 
             if ( $children = _get_term_children( $term->term_id, $terms, $taxonomy, $ancestors) )